| Message ID | 87r3xo1xak.wl%kuninori.morimoto.gx@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Fri, Oct 31, 2014 at 01:02:59AM -0700, Kuninori Morimoto wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current Koelsch I2C2 has 400kHz settings, > but, ak4643 audio codec chip which is connected to I2C2 can't > work such frequency. > Fixup I2C2 clock frequency. Basically OK, but we should better explicitly set it to 100000 and not rely on a default coming from somewhere. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > --- > arch/arm/boot/dts/r8a7791-koelsch.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts > index f722821..1ad9fb3 100644 > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts > @@ -425,7 +425,6 @@ > pinctrl-names = "default"; > > status = "okay"; > - clock-frequency = <400000>; > > composite-in@20 { > compatible = "adi,adv7180"; > -- > 1.7.9.5 >
Hi Wolfram, Simon > > Current Koelsch I2C2 has 400kHz settings, > > but, ak4643 audio codec chip which is connected to I2C2 can't > > work such frequency. > > Fixup I2C2 clock frequency. > > Basically OK, but we should better explicitly set it to 100000 and not > rely on a default coming from somewhere. OK. Simon Lager board is expecting that I2C is working with 100000 too. Can you accept this patch as-is ? if so, I will send additional clock frequency 100000 setting patch for both lager/koelsch. If not, I will send v2 of this patch-set + lager clock frequency patch. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Oct 31, 2014 at 01:44:35AM -0700, Kuninori Morimoto wrote: > > Hi Wolfram, Simon > > > > Current Koelsch I2C2 has 400kHz settings, > > > but, ak4643 audio codec chip which is connected to I2C2 can't > > > work such frequency. > > > Fixup I2C2 clock frequency. > > > > Basically OK, but we should better explicitly set it to 100000 and not > > rely on a default coming from somewhere. > > OK. > > Simon > Lager board is expecting that I2C is working with 100000 too. > Can you accept this patch as-is ? if so, I will send > additional clock frequency 100000 setting patch for both lager/koelsch. > If not, I will send v2 of this patch-set + lager clock frequency patch. Could send a small patchset that only fixes up all the clock frequency problems? That would be easiest for me. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon > > Lager board is expecting that I2C is working with 100000 too. > > Can you accept this patch as-is ? if so, I will send > > additional clock frequency 100000 setting patch for both lager/koelsch. > > If not, I will send v2 of this patch-set + lager clock frequency patch. > > Could send a small patchset that only fixes up all the clock frequency > problems? That would be easiest for me. Done. I sent v3 patch-set which includes above Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts b/arch/arm/boot/dts/r8a7791-koelsch.dts index f722821..1ad9fb3 100644 --- a/arch/arm/boot/dts/r8a7791-koelsch.dts +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts @@ -425,7 +425,6 @@ pinctrl-names = "default"; status = "okay"; - clock-frequency = <400000>; composite-in@20 { compatible = "adi,adv7180";