| Message ID | 1413290117-13082-8-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Oct 14, 2014 at 2:35 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > Use power_supply_put() to decrement the power supply's device reference > counter. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote: > Use power_supply_put() to decrement the power supply's device reference > counter. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/mfd/ab8500-sysctrl.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks. > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c > index 93b2d2c32ca3..d05a5719cfc4 100644 > --- a/drivers/mfd/ab8500-sysctrl.c > +++ b/drivers/mfd/ab8500-sysctrl.c > @@ -51,6 +51,7 @@ static void ab8500_power_off(void) > > ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE, > &val); > + power_supply_put(psy); > > if (!ret && val.intval) { > charger_present = true; > @@ -73,6 +74,7 @@ static void ab8500_power_off(void) > pss[i]); > machine_restart("charging"); > } > + power_supply_put(psy); > } > > shutdown:
On Mon, 03 Nov 2014, Lee Jones wrote: > On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote: > > > Use power_supply_put() to decrement the power supply's device reference > > counter. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > drivers/mfd/ab8500-sysctrl.c | 2 ++ > > 1 file changed, 2 insertions(+) > > Applied, thanks. Whoops, to hasty there -- unapplied. What's going on with this set? > > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c > > index 93b2d2c32ca3..d05a5719cfc4 100644 > > --- a/drivers/mfd/ab8500-sysctrl.c > > +++ b/drivers/mfd/ab8500-sysctrl.c > > @@ -51,6 +51,7 @@ static void ab8500_power_off(void) > > > > ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE, > > &val); > > + power_supply_put(psy); > > > > if (!ret && val.intval) { > > charger_present = true; > > @@ -73,6 +74,7 @@ static void ab8500_power_off(void) > > pss[i]); > > machine_restart("charging"); > > } > > + power_supply_put(psy); > > } > > > > shutdown: >
On pon, 2014-11-03 at 18:00 +0000, Lee Jones wrote: > On Mon, 03 Nov 2014, Lee Jones wrote: > > > On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote: > > > > > Use power_supply_put() to decrement the power supply's device reference > > > counter. > > > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > > --- > > > drivers/mfd/ab8500-sysctrl.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > Applied, thanks. > > Whoops, to hasty there -- unapplied. > > What's going on with this set? The set should be pulled at once (everything depends on 1st patch). It is still waiting for reviews. I'll resend soon. Best regards, Krzysztof > > > > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c > > > index 93b2d2c32ca3..d05a5719cfc4 100644 > > > --- a/drivers/mfd/ab8500-sysctrl.c > > > +++ b/drivers/mfd/ab8500-sysctrl.c > > > @@ -51,6 +51,7 @@ static void ab8500_power_off(void) > > > > > > ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE, > > > &val); > > > + power_supply_put(psy); > > > > > > if (!ret && val.intval) { > > > charger_present = true; > > > @@ -73,6 +74,7 @@ static void ab8500_power_off(void) > > > pss[i]); > > > machine_restart("charging"); > > > } > > > + power_supply_put(psy); > > > } > > > > > > shutdown: > > >
diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c index 93b2d2c32ca3..d05a5719cfc4 100644 --- a/drivers/mfd/ab8500-sysctrl.c +++ b/drivers/mfd/ab8500-sysctrl.c @@ -51,6 +51,7 @@ static void ab8500_power_off(void) ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE, &val); + power_supply_put(psy); if (!ret && val.intval) { charger_present = true; @@ -73,6 +74,7 @@ static void ab8500_power_off(void) pss[i]); machine_restart("charging"); } + power_supply_put(psy); } shutdown:
Use power_supply_put() to decrement the power supply's device reference counter. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- drivers/mfd/ab8500-sysctrl.c | 2 ++ 1 file changed, 2 insertions(+)