| Message ID | 1415045985-60963-1-git-send-email-dros@primarydata.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
I’m not sure it we want to CC stable on this one - the single warning can simply be ignored. -dros > On Nov 3, 2014, at 3:19 PM, Weston Andros Adamson <dros@primarydata.com> wrote: > > This WARN_ON_ONCE was supposed to catch reference counting bugs, but can > trigger in inappropriate situations. > > This was reproducible using NFSv2 on an architecture with 64K pages -- we > verified that it was not a reference counting bug and the warning was > safe to ignore. > > Reported-by: Will Deacon <will.deacon@arm.com> > Tested-by: Will Deacon <will.deacon@arm.com> > Signed-off-by: Weston Andros Adamson <dros@primarydata.com> > --- > fs/nfs/write.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/nfs/write.c b/fs/nfs/write.c > index 12493846a2d3..f83b02dc9166 100644 > --- a/fs/nfs/write.c > +++ b/fs/nfs/write.c > @@ -715,8 +715,6 @@ static void nfs_inode_remove_request(struct nfs_page *req) > > if (test_and_clear_bit(PG_INODE_REF, &req->wb_flags)) > nfs_release_request(req); > - else > - WARN_ON_ONCE(1); > } > > static void > -- > 1.9.3 (Apple Git-50) > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 12493846a2d3..f83b02dc9166 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c @@ -715,8 +715,6 @@ static void nfs_inode_remove_request(struct nfs_page *req) if (test_and_clear_bit(PG_INODE_REF, &req->wb_flags)) nfs_release_request(req); - else - WARN_ON_ONCE(1); } static void