diff mbox

mmc: dw_mmc: add the message for deprecating supports-highspeed

Message ID 1415089855-18366-1-git-send-email-jh80.chung@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jaehoon Chung Nov. 4, 2014, 8:30 a.m. UTC
Recommend to use "mmc-cap-highspeed" or "sd-cap-highspeed" instead of
"supports-highspeed".
Although "supports-highspeed" supports, devloper can use
"mmc-cap-highspeed" or "sd-cap-highspeed" through this message.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/host/dw_mmc.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Ulf Hansson Nov. 5, 2014, 1:06 p.m. UTC | #1
On 4 November 2014 09:30, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Recommend to use "mmc-cap-highspeed" or "sd-cap-highspeed" instead of
> "supports-highspeed".
> Although "supports-highspeed" supports, devloper can use
> "mmc-cap-highspeed" or "sd-cap-highspeed" through this message.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>

This one has checkpatch warnings. Please send an updated version.

Kind regards
Uffe

> ---
>  drivers/mmc/host/dw_mmc.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index bb46b1b..7075d33 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2434,8 +2434,11 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>                         return ERR_PTR(ret);
>         }
>
> -       if (of_find_property(np, "supports-highspeed", NULL))
> +       if (of_find_property(np, "supports-highspeed", NULL)) {
> +               dev_warn(dev, "supports-highspeed is deprecated. "
> +                               "Use cap-mmc-highspeed or cap-sd-highspeed.\n");
>                 pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
> +       }
>
>         return pdata;
>  }
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index bb46b1b..7075d33 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -2434,8 +2434,11 @@  static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
 			return ERR_PTR(ret);
 	}
 
-	if (of_find_property(np, "supports-highspeed", NULL))
+	if (of_find_property(np, "supports-highspeed", NULL)) {
+		dev_warn(dev, "supports-highspeed is deprecated. "
+				"Use cap-mmc-highspeed or cap-sd-highspeed.\n");
 		pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
+	}
 
 	return pdata;
 }