| Message ID | 200909021630.15607.sshtylyov@ru.mvista.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, I wrote: > Commit 30899ca7f20571c4bd64544dec261171f6ec255b (USB: musb: davinci dm6446evm > GPIO renumbering) has updated GPIO_nVBUS_DRV to a wrong value which causes a > kernel oops. > The DaVinci chips have 104 GPIOs max, not 128, hence the correct value is 120 > (that is 104 + 8 + 8), not 144. > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > --- > Please, apply it before 2.6.31 is out as it fixes a kernel oops... Ping. WBR, Sergei
Hello, I wrote: >> Commit 30899ca7f20571c4bd64544dec261171f6ec255b (USB: musb: davinci >> dm6446evm >> GPIO renumbering) has updated GPIO_nVBUS_DRV to a wrong value which >> causes a >> kernel oops. > >> The DaVinci chips have 104 GPIOs max, not 128, hence the correct >> value is 120 >> (that is 104 + 8 + 8), not 144. > >> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > >> --- >> Please, apply it before 2.6.31 is out as it fixes a kernel oops... > > Ping. David, Greg is waiting for your ACKs (or NAKs) on my several outstanding MUSB patches... we've already missed 2.6.31. :-/ WBR, Sergei
Index: linux-2.6/drivers/usb/musb/davinci.c =================================================================== --- linux-2.6.orig/drivers/usb/musb/davinci.c +++ linux-2.6/drivers/usb/musb/davinci.c @@ -42,7 +42,7 @@ #include "musb_core.h" #ifdef CONFIG_MACH_DAVINCI_EVM -#define GPIO_nVBUS_DRV 144 +#define GPIO_nVBUS_DRV 120 #endif #include "davinci.h"
Commit 30899ca7f20571c4bd64544dec261171f6ec255b (USB: musb: davinci dm6446evm GPIO renumbering) has updated GPIO_nVBUS_DRV to a wrong value which causes a kernel oops. The DaVinci chips have 104 GPIOs max, not 128, hence the correct value is 120 (that is 104 + 8 + 8), not 144. Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> --- Please, apply it before 2.6.31 is out as it fixes a kernel oops... drivers/usb/musb/davinci.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)