diff mbox

[2/3] gpio: arizona: Add support for CS47L24

Message ID 20141111170432.GB25738@opensource.wolfsonmicro.com (mailing list archive)
State New, archived
Headers show

Commit Message

Richard Fitzgerald Nov. 11, 2014, 5:04 p.m. UTC 
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
 drivers/gpio/gpio-arizona.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Comments

Mark Brown Nov. 11, 2014, 5:16 p.m. UTC | #1 
On Tue, Nov 11, 2014 at 05:04:32PM +0000, Richard Fitzgerald wrote:

> + * Copyright 2014 CirrusLogic, Inc.

Deathtospaces.
Linus Walleij Nov. 17, 2014, 6:41 a.m. UTC | #2 
On Tue, Nov 11, 2014 at 6:04 PM, Richard Fitzgerald
<rf@opensource.wolfsonmicro.com> wrote:

> Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>

Apart from the whitespace fix pointed out by Mark,
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Richard Fitzgerald Nov. 17, 2014, 9:58 a.m. UTC | #3 
On Mon, Nov 17, 2014 at 07:41:53AM +0100, Linus Walleij wrote:
> On Tue, Nov 11, 2014 at 6:04 PM, Richard Fitzgerald
> <rf@opensource.wolfsonmicro.com> wrote:
> 
> > Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
> 
> Apart from the whitespace fix pointed out by Mark,

THe line Mark commented on isn't a whitespace error. It matches
the copyright line style used by Cirrus in other files.

> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Yours,
> Linus Walleij
Mark Brown Nov. 17, 2014, 3:03 p.m. UTC | #4 
On Mon, Nov 17, 2014 at 09:58:01AM +0000, Richard Fitzgerald wrote:
> On Mon, Nov 17, 2014 at 07:41:53AM +0100, Linus Walleij wrote:

> > Apart from the whitespace fix pointed out by Mark,

> THe line Mark commented on isn't a whitespace error. It matches
> the copyright line style used by Cirrus in other files.

Are you sure you're not copying a mistake someone else introduced here
or that if it is in some way deliberate it's a good idea?
diff mbox

Patch

diff --git a/drivers/gpio/gpio-arizona.c b/drivers/gpio/gpio-arizona.c
index fe369f5..9e29ed0 100644
--- a/drivers/gpio/gpio-arizona.c
+++ b/drivers/gpio/gpio-arizona.c
@@ -1,6 +1,7 @@ 
 /*
  * gpiolib support for Wolfson Arizona class devices
  *
+ * Copyright 2014 CirrusLogic, Inc.
  * Copyright 2012 Wolfson Microelectronics PLC.
  *
  * Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
@@ -119,6 +120,10 @@  static int arizona_gpio_probe(struct platform_device *pdev)
 	case WM8997:
 		arizona_gpio->gpio_chip.ngpio = 5;
 		break;
+	case WM1831:
+	case CS47L24:
+		arizona_gpio->gpio_chip.ngpio = 2;
+		break;
 	default:
 		dev_err(&pdev->dev, "Unknown chip variant %d\n",
 			arizona->type);