| Message ID | 002601cffe27$f7bca9f0$e735fdd0$%han@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Wed, Nov 12, 2014 at 12:22:56PM +0900, Jingoo Han wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. This patch > fixes the following checkpatch warning. > > WARNING: Possible unnecessary 'out of memory' message > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Applied to pci/host-keystone for v3.19, thanks! Murali, let me know if you object. I'm trying to clear the easy stuff out of my queue. > --- > drivers/pci/host/pci-keystone.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c > index 1b893bc..62b9454 100644 > --- a/drivers/pci/host/pci-keystone.c > +++ b/drivers/pci/host/pci-keystone.c > @@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev) > > ks_pcie = devm_kzalloc(&pdev->dev, sizeof(*ks_pcie), > GFP_KERNEL); > - if (!ks_pcie) { > - dev_err(dev, "no memory for keystone pcie\n"); > + if (!ks_pcie) > return -ENOMEM; > - } > + > pp = &ks_pcie->pp; > > /* initialize SerDes Phy if present */ > -- > 1.7.9.5 > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/13/2014 12:47 PM, Bjorn Helgaas wrote: > On Wed, Nov 12, 2014 at 12:22:56PM +0900, Jingoo Han wrote: >> The site-specific OOM messages are unnecessary, because they >> duplicate the MM subsystem generic OOM message. This patch >> fixes the following checkpatch warning. >> >> WARNING: Possible unnecessary 'out of memory' message >> >> Signed-off-by: Jingoo Han<jg1.han@samsung.com> > Applied to pci/host-keystone for v3.19, thanks! > > Murali, let me know if you object. I'm trying to clear the easy stuff out > of my queue. I think this checkpatch warning is due to recent update to checkpatch.pl script. Looks good to apply. Thanks Murali >> --- >> drivers/pci/host/pci-keystone.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c >> index 1b893bc..62b9454 100644 >> --- a/drivers/pci/host/pci-keystone.c >> +++ b/drivers/pci/host/pci-keystone.c >> @@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev) >> >> ks_pcie = devm_kzalloc(&pdev->dev, sizeof(*ks_pcie), >> GFP_KERNEL); >> - if (!ks_pcie) { >> - dev_err(dev, "no memory for keystone pcie\n"); >> + if (!ks_pcie) >> return -ENOMEM; >> - } >> + >> pp =&ks_pcie->pp; >> >> /* initialize SerDes Phy if present */ >> -- >> 1.7.9.5 >> >>
diff --git a/drivers/pci/host/pci-keystone.c b/drivers/pci/host/pci-keystone.c index 1b893bc..62b9454 100644 --- a/drivers/pci/host/pci-keystone.c +++ b/drivers/pci/host/pci-keystone.c @@ -353,10 +353,9 @@ static int __init ks_pcie_probe(struct platform_device *pdev) ks_pcie = devm_kzalloc(&pdev->dev, sizeof(*ks_pcie), GFP_KERNEL); - if (!ks_pcie) { - dev_err(dev, "no memory for keystone pcie\n"); + if (!ks_pcie) return -ENOMEM; - } + pp = &ks_pcie->pp; /* initialize SerDes Phy if present */
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. This patch fixes the following checkpatch warning. WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/pci/host/pci-keystone.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)