diff mbox

[4/7] drm/exynos: fimd: move handle vblank position in TE handler

Message ID 1412144353-13114-5-git-send-email-yj44.cho@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

YoungJun Cho Oct. 1, 2014, 6:19 a.m. UTC 
For providing VBLANK information, drm_handle_vblank() should
be called properly, but it is blocked by wait_vsync_event
condition which is set by manager_ops->wait_for_vblank().
So moves it out from wait_vsync_event routine.

Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
Acked-by: Inki Dae <inki.dae@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Inki Dae Nov. 14, 2014, 1:20 a.m. UTC | #1 
On 2014? 10? 01? 15:19, YoungJun Cho wrote:
> For providing VBLANK information, drm_handle_vblank() should
> be called properly, but it is blocked by wait_vsync_event
> condition which is set by manager_ops->wait_for_vblank().
> So moves it out from wait_vsync_event routine.

Applied.

Thanks,
Inki Dae

> 
> Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
> Acked-by: Inki Dae <inki.dae@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> index 05c2a97a..f062335 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
> @@ -983,10 +983,10 @@ static void fimd_te_handler(struct exynos_drm_manager *mgr)
>  	if (atomic_read(&ctx->wait_vsync_event)) {
>  		atomic_set(&ctx->wait_vsync_event, 0);
>  		wake_up(&ctx->wait_vsync_queue);
> -
> -		if (!atomic_read(&ctx->triggering))
> -			drm_handle_vblank(ctx->drm_dev, ctx->pipe);
>  	}
> +
> +	if (!atomic_read(&ctx->triggering))
> +		drm_handle_vblank(ctx->drm_dev, ctx->pipe);
>  }
>  
>  static struct exynos_drm_manager_ops fimd_manager_ops = {
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 05c2a97a..f062335 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -983,10 +983,10 @@  static void fimd_te_handler(struct exynos_drm_manager *mgr)
 	if (atomic_read(&ctx->wait_vsync_event)) {
 		atomic_set(&ctx->wait_vsync_event, 0);
 		wake_up(&ctx->wait_vsync_queue);
-
-		if (!atomic_read(&ctx->triggering))
-			drm_handle_vblank(ctx->drm_dev, ctx->pipe);
 	}
+
+	if (!atomic_read(&ctx->triggering))
+		drm_handle_vblank(ctx->drm_dev, ctx->pipe);
 }
 
 static struct exynos_drm_manager_ops fimd_manager_ops = {