diff mbox

[5/7] dmaengine: at_xdmac: fix missing spin_unlock

Message ID 1415875965-6905-6-git-send-email-ludovic.desroches@atmel.com (mailing list archive)
State Superseded
Headers show

Commit Message

Ludovic Desroches Nov. 13, 2014, 10:52 a.m. UTC
Lock taken when entering the function but unlock missing before it
returns.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 drivers/dma/at_xdmac.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul Nov. 17, 2014, 8:31 a.m. UTC | #1
On Thu, Nov 13, 2014 at 11:52:43AM +0100, Ludovic Desroches wrote:
> Lock taken when entering the function but unlock missing before it
> returns.
> 
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
I am adding reported to tag  here for Dan's report
diff mbox

Patch

diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index bf2aacb..586275f 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -901,6 +901,7 @@  at_xdmac_tx_status(struct dma_chan *chan, dma_cookie_t cookie,
 	 */
 	if (!desc->active_xfer) {
 		dma_set_residue(txstate, desc->xfer_size);
+		spin_unlock_bh(&atchan->lock);
 		return ret;
 	}