| Message ID | 1415904621-26800-1-git-send-email-abrestic@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Andrew, On Thu, Nov 13, 2014 at 10:50 AM, Andrew Bresticker <abrestic@chromium.org> wrote: > Add support for the DW MMC host found on the Imagination Pistachio SoC. > Like the DW MMC hosts found on SOCFPGA and Rockchip SoCs, the DW MMC > host on Pistachio requires the use of SDMMC_CMD_USE_HOLD_REG. > > Signed-off-by: Andrew Bresticker <abrestic@chromium.org> > --- > .../devicetree/bindings/mmc/img-dw-mshc.txt | 29 ++++++++++++++++++++++ > drivers/mmc/host/dw_mmc-pltfm.c | 6 +++++ > 2 files changed, 35 insertions(+) This seems quite sane to me. Reviewed-by: Doug Anderson <dianders@chromium.org> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/19/2014 02:28 AM, Doug Anderson wrote: > Andrew, > > On Thu, Nov 13, 2014 at 10:50 AM, Andrew Bresticker > <abrestic@chromium.org> wrote: >> Add support for the DW MMC host found on the Imagination Pistachio SoC. >> Like the DW MMC hosts found on SOCFPGA and Rockchip SoCs, the DW MMC >> host on Pistachio requires the use of SDMMC_CMD_USE_HOLD_REG. >> >> Signed-off-by: Andrew Bresticker <abrestic@chromium.org> >> --- >> .../devicetree/bindings/mmc/img-dw-mshc.txt | 29 ++++++++++++++++++++++ >> drivers/mmc/host/dw_mmc-pltfm.c | 6 +++++ >> 2 files changed, 35 insertions(+) > > This seems quite sane to me. > > Reviewed-by: Doug Anderson <dianders@chromium.org> Acked-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 13 November 2014 19:50, Andrew Bresticker <abrestic@chromium.org> wrote: > Add support for the DW MMC host found on the Imagination Pistachio SoC. > Like the DW MMC hosts found on SOCFPGA and Rockchip SoCs, the DW MMC > host on Pistachio requires the use of SDMMC_CMD_USE_HOLD_REG. > > Signed-off-by: Andrew Bresticker <abrestic@chromium.org> Thanks! Applied for next. Kind regards Uffe > --- > .../devicetree/bindings/mmc/img-dw-mshc.txt | 29 ++++++++++++++++++++++ > drivers/mmc/host/dw_mmc-pltfm.c | 6 +++++ > 2 files changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/img-dw-mshc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/img-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/img-dw-mshc.txt > new file mode 100644 > index 0000000..85de99f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/img-dw-mshc.txt > @@ -0,0 +1,29 @@ > +* Imagination specific extensions to the Synopsys Designware Mobile Storage > + Host Controller > + > +The Synopsys designware mobile storage host controller is used to interface > +a SoC with storage medium such as eMMC or SD/MMC cards. This file documents > +differences between the core Synopsys dw mshc controller properties described > +by synopsys-dw-mshc.txt and the properties used by the Imagination specific > +extensions to the Synopsys Designware Mobile Storage Host Controller. > + > +Required Properties: > + > +* compatible: should be > + - "img,pistachio-dw-mshc": for Pistachio SoCs > + > +Example: > + > + mmc@18142000 { > + compatible = "img,pistachio-dw-mshc"; > + reg = <0x18142000 0x400>; > + interrupts = <GIC_SHARED 39 IRQ_TYPE_LEVEL_HIGH>; > + > + clocks = <&system_clk>, <&sdhost_clk>; > + clock-names = "biu", "ciu"; > + > + fifo-depth = <0x20>; > + bus-width = <4>; > + num-slots = <1>; > + disable-wp; > + }; > diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c > index 8b65721..ec6dbcd 100644 > --- a/drivers/mmc/host/dw_mmc-pltfm.c > +++ b/drivers/mmc/host/dw_mmc-pltfm.c > @@ -35,6 +35,10 @@ static const struct dw_mci_drv_data socfpga_drv_data = { > .prepare_command = dw_mci_pltfm_prepare_command, > }; > > +static const struct dw_mci_drv_data pistachio_drv_data = { > + .prepare_command = dw_mci_pltfm_prepare_command, > +}; > + > int dw_mci_pltfm_register(struct platform_device *pdev, > const struct dw_mci_drv_data *drv_data) > { > @@ -90,6 +94,8 @@ static const struct of_device_id dw_mci_pltfm_match[] = { > { .compatible = "snps,dw-mshc", }, > { .compatible = "altr,socfpga-dw-mshc", > .data = &socfpga_drv_data }, > + { .compatible = "img,pistachio-dw-mshc", > + .data = &pistachio_drv_data }, > {}, > }; > MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match); > -- > 2.1.0.rc2.206.gedb03e5 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mmc/img-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/img-dw-mshc.txt new file mode 100644 index 0000000..85de99f --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/img-dw-mshc.txt @@ -0,0 +1,29 @@ +* Imagination specific extensions to the Synopsys Designware Mobile Storage + Host Controller + +The Synopsys designware mobile storage host controller is used to interface +a SoC with storage medium such as eMMC or SD/MMC cards. This file documents +differences between the core Synopsys dw mshc controller properties described +by synopsys-dw-mshc.txt and the properties used by the Imagination specific +extensions to the Synopsys Designware Mobile Storage Host Controller. + +Required Properties: + +* compatible: should be + - "img,pistachio-dw-mshc": for Pistachio SoCs + +Example: + + mmc@18142000 { + compatible = "img,pistachio-dw-mshc"; + reg = <0x18142000 0x400>; + interrupts = <GIC_SHARED 39 IRQ_TYPE_LEVEL_HIGH>; + + clocks = <&system_clk>, <&sdhost_clk>; + clock-names = "biu", "ciu"; + + fifo-depth = <0x20>; + bus-width = <4>; + num-slots = <1>; + disable-wp; + }; diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c index 8b65721..ec6dbcd 100644 --- a/drivers/mmc/host/dw_mmc-pltfm.c +++ b/drivers/mmc/host/dw_mmc-pltfm.c @@ -35,6 +35,10 @@ static const struct dw_mci_drv_data socfpga_drv_data = { .prepare_command = dw_mci_pltfm_prepare_command, }; +static const struct dw_mci_drv_data pistachio_drv_data = { + .prepare_command = dw_mci_pltfm_prepare_command, +}; + int dw_mci_pltfm_register(struct platform_device *pdev, const struct dw_mci_drv_data *drv_data) { @@ -90,6 +94,8 @@ static const struct of_device_id dw_mci_pltfm_match[] = { { .compatible = "snps,dw-mshc", }, { .compatible = "altr,socfpga-dw-mshc", .data = &socfpga_drv_data }, + { .compatible = "img,pistachio-dw-mshc", + .data = &pistachio_drv_data }, {}, }; MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match);
Add support for the DW MMC host found on the Imagination Pistachio SoC. Like the DW MMC hosts found on SOCFPGA and Rockchip SoCs, the DW MMC host on Pistachio requires the use of SDMMC_CMD_USE_HOLD_REG. Signed-off-by: Andrew Bresticker <abrestic@chromium.org> --- .../devicetree/bindings/mmc/img-dw-mshc.txt | 29 ++++++++++++++++++++++ drivers/mmc/host/dw_mmc-pltfm.c | 6 +++++ 2 files changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/mmc/img-dw-mshc.txt