| Message ID | 1414401440-10972-1-git-send-email-javier.martinez@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Javier Martinez Canillas wrote: > Hi, > Commit 6e80e3d87549 ("ARM: exynos_defconfig: Enable MAX77802") > enabled support for the max77802 regulators but the PMIC also > has a Real-Time-Clock (RTC) and 2-channel 32kHz clock outputs. > Yes, right. > Enable the kernel config options to have the drivers for these > devices built-in since they are present in many Exynos boards. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Acked-by: Kevin Hilman <khilman@linaro.org> > Tested-by: Kevin Hilman <khilman@linaro.org> > --- > > This patch supersedes [0] since commit "ARM: exynos_defconfig: savedefconfig" > is not present in linux-next anymore which disabled among other options, the > max77802 support. > Yeah, I talked about savedefconfig with Bart and I decided to revert it at that time. > However, support for the max77802 rtc and clocks were not enabled on exynos > defconfig so $subject is still needed. > > Kevin, I carried your tags from [0] since $subject enables the options you > needed to get RTC wakeup from suspend working on exynos5800-peach-pi. Please > let me know if they no longer applies. > > Best regards, > Javier > > [0]: https://lkml.org/lkml/2014/10/9/413 > > arch/arm/configs/exynos_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 72058b8..e21ef83 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -142,11 +142,13 @@ CONFIG_MMC_DW_IDMAC=y > CONFIG_MMC_DW_EXYNOS=y > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX77686=y > +CONFIG_RTC_DRV_MAX77802=y > CONFIG_RTC_DRV_S5M=y > CONFIG_RTC_DRV_S3C=y > CONFIG_DMADEVICES=y > CONFIG_PL330_DMA=y > CONFIG_COMMON_CLK_MAX77686=y > +CONFIG_COMMON_CLK_MAX77802=y > CONFIG_COMMON_CLK_S2MPS11=y > CONFIG_EXYNOS_IOMMU=y > CONFIG_IIO=y > -- > 2.1.0 I'll apply this, thanks. - Kukjin
Hello Kukjin, On Tue, Oct 28, 2014 at 12:06 PM, Kukjin Kim <kgene@kernel.org> wrote: > Javier Martinez Canillas wrote: >> Commit 6e80e3d87549 ("ARM: exynos_defconfig: Enable MAX77802") >> enabled support for the max77802 regulators but the PMIC also >> has a Real-Time-Clock (RTC) and 2-channel 32kHz clock outputs. >> > > I'll apply this, thanks. > > - Kukjin > You say that you will apply this patch but I can't find it in any of your branches. Best regards, Javier
On 11/13/14 17:45, Javier Martinez Canillas wrote: > Hello Kukjin, > Hi Javier, > On Tue, Oct 28, 2014 at 12:06 PM, Kukjin Kim <kgene@kernel.org> wrote: >> Javier Martinez Canillas wrote: >>> Commit 6e80e3d87549 ("ARM: exynos_defconfig: Enable MAX77802") >>> enabled support for the max77802 regulators but the PMIC also >>> has a Real-Time-Clock (RTC) and 2-channel 32kHz clock outputs. >>> >> >> I'll apply this, thanks. >> >> - Kukjin >> > > You say that you will apply this patch but I can't find it in any of > your branches. > Sorry for missing the patch in my tree. You can see it in a couple of mins ;) Thanks, Kukjin
Hello Kukjin, On 11/19/2014 09:09 AM, Kukjin Kim wrote: >> You say that you will apply this patch but I can't find it in any of >> your branches. >> > Sorry for missing the patch in my tree. You can see it in a couple of > mins ;) > Great, thanks a lot! Best regards, Javier
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 72058b8..e21ef83 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -142,11 +142,13 @@ CONFIG_MMC_DW_IDMAC=y CONFIG_MMC_DW_EXYNOS=y CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX77686=y +CONFIG_RTC_DRV_MAX77802=y CONFIG_RTC_DRV_S5M=y CONFIG_RTC_DRV_S3C=y CONFIG_DMADEVICES=y CONFIG_PL330_DMA=y CONFIG_COMMON_CLK_MAX77686=y +CONFIG_COMMON_CLK_MAX77802=y CONFIG_COMMON_CLK_S2MPS11=y CONFIG_EXYNOS_IOMMU=y CONFIG_IIO=y
Commit 6e80e3d87549 ("ARM: exynos_defconfig: Enable MAX77802") enabled support for the max77802 regulators but the PMIC also has a Real-Time-Clock (RTC) and 2-channel 32kHz clock outputs. Enable the kernel config options to have the drivers for these devices built-in since they are present in many Exynos boards. Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> Acked-by: Kevin Hilman <khilman@linaro.org> Tested-by: Kevin Hilman <khilman@linaro.org> --- This patch supersedes [0] since commit "ARM: exynos_defconfig: savedefconfig" is not present in linux-next anymore which disabled among other options, the max77802 support. However, support for the max77802 rtc and clocks were not enabled on exynos defconfig so $subject is still needed. Kevin, I carried your tags from [0] since $subject enables the options you needed to get RTC wakeup from suspend working on exynos5800-peach-pi. Please let me know if they no longer applies. Best regards, Javier [0]: https://lkml.org/lkml/2014/10/9/413 arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2 insertions(+)