| Message ID | 546CC755.4010804@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On November 19, 2014 5:42:26 PM SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 19 Nov 2014 17:33:32 +0100 > > The vunmap() function performes also input parameter validation. Thus the test > around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/gpu/drm/udl/udl_gem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c > index 8044f5f..2979625 100644 > --- a/drivers/gpu/drm/udl/udl_gem.c > +++ b/drivers/gpu/drm/udl/udl_gem.c > @@ -164,8 +164,7 @@ void udl_gem_vunmap(struct udl_gem_object *obj) > return; > } > > - if (obj->vmapping) > - vunmap(obj->vmapping); > + vunmap(obj->vmapping); > > udl_gem_put_pages(obj); > } Reviewed-by: Thierry Reding <thierry.reding@gmail.com>
diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c index 8044f5f..2979625 100644 --- a/drivers/gpu/drm/udl/udl_gem.c +++ b/drivers/gpu/drm/udl/udl_gem.c @@ -164,8 +164,7 @@ void udl_gem_vunmap(struct udl_gem_object *obj) return; } - if (obj->vmapping) - vunmap(obj->vmapping); + vunmap(obj->vmapping); udl_gem_put_pages(obj); }