| Message ID | 1410360223-18363-1-git-send-email-s.nawrocki@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/09/14 16:43, Sylwester Nawrocki wrote: > This ensures the core and the audio subsystem clocks are configured > properly, as expected by the sound machine driver. These bits are > missing to obtain proper audio sample rates in kernel v3.17, where > audio support for Odroid X2/U3 was first added. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > It would be good to have it applied as a fix for v3.17. Anything happened to this patch ? I can't see it neither in Linus' nor -next tree. And we are already at 3.18 merge window. > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > index adadaf9..b40f766 100644 > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > @@ -45,6 +45,16 @@ > compatible = "samsung,odroidx2-audio"; > samsung,i2s-controller = <&i2s0>; > samsung,audio-codec = <&max98090>; > + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>, > + <&clock_audss EXYNOS_MOUT_I2S>, > + <&clock_audss EXYNOS_DOUT_SRP>, > + <&clock_audss EXYNOS_DOUT_AUD_BUS>; > + assigned-clock-parents = <&clock CLK_FOUT_EPLL>, > + <&clock_audss EXYNOS_MOUT_AUDSS>; > + assigned-clock-rates = <0>, > + <0>, > + <192000000>, > + <19200000>; > }; > > mmc@12550000 { > -- > 1.7.9.5
Sylwester Nawrocki wrote: > > On 10/09/14 16:43, Sylwester Nawrocki wrote: > > This ensures the core and the audio subsystem clocks are configured > > properly, as expected by the sound machine driver. These bits are > > missing to obtain proper audio sample rates in kernel v3.17, where > > audio support for Odroid X2/U3 was first added. > > > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > > --- > > It would be good to have it applied as a fix for v3.17. > > Anything happened to this patch ? I can't see it neither in Linus' nor > -next tree. And we are already at 3.18 merge window. > Hi Sylwester, Sorry about that. I'll queue this one into fixes for -3.18 and stable maybe +3.17 only if stable-3.17 is available... Thanks for your gentle reminder. - Kukjin > > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid- > common.dtsi > > index adadaf9..b40f766 100644 > > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > > @@ -45,6 +45,16 @@ > > compatible = "samsung,odroidx2-audio"; > > samsung,i2s-controller = <&i2s0>; > > samsung,audio-codec = <&max98090>; > > + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>, > > + <&clock_audss EXYNOS_MOUT_I2S>, > > + <&clock_audss EXYNOS_DOUT_SRP>, > > + <&clock_audss EXYNOS_DOUT_AUD_BUS>; > > + assigned-clock-parents = <&clock CLK_FOUT_EPLL>, > > + <&clock_audss EXYNOS_MOUT_AUDSS>; > > + assigned-clock-rates = <0>, > > + <0>, > > + <192000000>, > > + <19200000>; > > }; > > > > mmc@12550000 { > > -- > > 1.7.9.5
On 07/10/14 03:51, Kukjin Kim wrote: >> > On 10/09/14 16:43, Sylwester Nawrocki wrote: >>> > > This ensures the core and the audio subsystem clocks are configured >>> > > properly, as expected by the sound machine driver. These bits are >>> > > missing to obtain proper audio sample rates in kernel v3.17, where >>> > > audio support for Odroid X2/U3 was first added. >>> > > >>> > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >>> > > --- >>> > > It would be good to have it applied as a fix for v3.17. >> > >> > Anything happened to this patch ? I can't see it neither in Linus' nor >> > -next tree. And we are already at 3.18 merge window. >> > > Hi Sylwester, > > Sorry about that. I'll queue this one into fixes for -3.18 and stable maybe > +3.17 only if stable-3.17 is available... Kukjin, You didn't forget about this patch, did you ? It's been over 2 months since I've sent it and sound on Odroid X2/U3 is still broken as it was then. Please send the patch upstream. -- Thanks, Sylwester
On 11/20/14 00:40, Sylwester Nawrocki wrote: > On 07/10/14 03:51, Kukjin Kim wrote: >>>> On 10/09/14 16:43, Sylwester Nawrocki wrote: >>>>>> This ensures the core and the audio subsystem clocks are configured >>>>>> properly, as expected by the sound machine driver. These bits are >>>>>> missing to obtain proper audio sample rates in kernel v3.17, where >>>>>> audio support for Odroid X2/U3 was first added. >>>>>> >>>>>> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >>>>>> --- >>>>>> It would be good to have it applied as a fix for v3.17. >>>> >>>> Anything happened to this patch ? I can't see it neither in Linus' nor >>>> -next tree. And we are already at 3.18 merge window. >>>> >> Hi Sylwester, >> >> Sorry about that. I'll queue this one into fixes for -3.18 and stable maybe >> +3.17 only if stable-3.17 is available... > > Kukjin, > > You didn't forget about this patch, did you ? > It's been over 2 months since I've sent it and sound on Odroid X2/U3 > is still broken as it was then. Please send the patch upstream. > Sylwester, I've applied this just now and if required, we need to send out to stable tree as well...sorry for that. Thanks, Kukjin
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index adadaf9..b40f766 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi @@ -45,6 +45,16 @@ compatible = "samsung,odroidx2-audio"; samsung,i2s-controller = <&i2s0>; samsung,audio-codec = <&max98090>; + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>, + <&clock_audss EXYNOS_MOUT_I2S>, + <&clock_audss EXYNOS_DOUT_SRP>, + <&clock_audss EXYNOS_DOUT_AUD_BUS>; + assigned-clock-parents = <&clock CLK_FOUT_EPLL>, + <&clock_audss EXYNOS_MOUT_AUDSS>; + assigned-clock-rates = <0>, + <0>, + <192000000>, + <19200000>; }; mmc@12550000 {
This ensures the core and the audio subsystem clocks are configured properly, as expected by the sound machine driver. These bits are missing to obtain proper audio sample rates in kernel v3.17, where audio support for Odroid X2/U3 was first added. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- It would be good to have it applied as a fix for v3.17. arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 1.7.9.5