| Message ID | 0ebec62b6a7196f970cd57cdcbcb850fdaa829bd.1253272938.git.quintela@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 18, 2009 at 01:41:10PM +0200, Juan Quintela wrote: > > Signed-off-by: Juan Quintela <quintela@redhat.com> > --- > configure | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 97292d9..e6252a2 100755 > --- a/configure > +++ b/configure > @@ -1758,8 +1758,6 @@ if test -z "$werror" ; then > else > werror="no" > fi > - # disable default werror for kvm > - werror="no" > fi > > if test "$werror" = "yes" ; then Don't know why Avi added this. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/18/2009 10:02 PM, Marcelo Tosatti wrote: > On Fri, Sep 18, 2009 at 01:41:10PM +0200, Juan Quintela wrote: > >> Signed-off-by: Juan Quintela<quintela@redhat.com> >> --- >> configure | 2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 97292d9..e6252a2 100755 >> --- a/configure >> +++ b/configure >> @@ -1758,8 +1758,6 @@ if test -z "$werror" ; then >> else >> werror="no" >> fi >> - # disable default werror for kvm >> - werror="no" >> fi >> >> if test "$werror" = "yes" ; then >> > Don't know why Avi added this. > The merge which introduced this also introduced warnings into qemu-kvm. If the warnings are gone, it's better to restore -Werror to upstream behaviour.
Avi Kivity wrote: > On 09/18/2009 10:02 PM, Marcelo Tosatti wrote: >> On Fri, Sep 18, 2009 at 01:41:10PM +0200, Juan Quintela wrote: >> >>> Signed-off-by: Juan Quintela<quintela@redhat.com> >>> --- >>> configure | 2 -- >>> 1 files changed, 0 insertions(+), 2 deletions(-) >>> >>> diff --git a/configure b/configure >>> index 97292d9..e6252a2 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -1758,8 +1758,6 @@ if test -z "$werror" ; then >>> else >>> werror="no" >>> fi >>> - # disable default werror for kvm >>> - werror="no" >>> fi >>> >>> if test "$werror" = "yes" ; then >>> >> Don't know why Avi added this. >> > > The merge which introduced this also introduced warnings into qemu-kvm. > If the warnings are gone, it's better to restore -Werror to upstream > behaviour. > --disable-kvm builds will fail, but maybe this motivates to clean up the related code. Jan
Jan Kiszka <jan.kiszka@web.de> wrote: > Avi Kivity wrote: >> On 09/18/2009 10:02 PM, Marcelo Tosatti wrote: >>> On Fri, Sep 18, 2009 at 01:41:10PM +0200, Juan Quintela wrote: >>> >>>> Signed-off-by: Juan Quintela<quintela@redhat.com> >>>> --- >>>> configure | 2 -- >>>> 1 files changed, 0 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/configure b/configure >>>> index 97292d9..e6252a2 100755 >>>> --- a/configure >>>> +++ b/configure >>>> @@ -1758,8 +1758,6 @@ if test -z "$werror" ; then >>>> else >>>> werror="no" >>>> fi >>>> - # disable default werror for kvm >>>> - werror="no" >>>> fi >>>> >>>> if test "$werror" = "yes" ; then >>>> >>> Don't know why Avi added this. >>> >> >> The merge which introduced this also introduced warnings into qemu-kvm. >> If the warnings are gone, it's better to restore -Werror to upstream >> behaviour. >> > > --disable-kvm builds will fail, but maybe this motivates to clean up the > related code. Failure is not -Werror related. msix.o, i8254-kvm.o and I stopped looking after that. Later, Juan. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/configure b/configure index 97292d9..e6252a2 100755 --- a/configure +++ b/configure @@ -1758,8 +1758,6 @@ if test -z "$werror" ; then else werror="no" fi - # disable default werror for kvm - werror="no" fi if test "$werror" = "yes" ; then
Signed-off-by: Juan Quintela <quintela@redhat.com> --- configure | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)