| Message ID | 20141127120856.17546.32014.stgit@potku.adurom.net (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Thursday 27 November 2014 14:08:56 Kalle Valo wrote: > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > new file mode 100644 > index 000000000000..edefc26c6204 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > @@ -0,0 +1,30 @@ > +* Qualcomm Atheros ath10k wireless devices > + > +For ath10k devices the calibration data can be provided through Device > +Tree. The node is a child node of the PCI controller. > + > +Required properties: > +-compatible : Should be "qcom,ath10k" > + > +Optional properties: > +- qcom,ath10k-calibration-data : calibration data as an array, the > + length can vary between hw versions > + Does the device always have a valid mac address in hardware? If not, how about listing that as well using the mac-address property? Arnd
Arnd Bergmann <arnd@arndb.de> writes: > On Thursday 27 November 2014 14:08:56 Kalle Valo wrote: >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> new file mode 100644 >> index 000000000000..edefc26c6204 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt >> @@ -0,0 +1,30 @@ >> +* Qualcomm Atheros ath10k wireless devices >> + >> +For ath10k devices the calibration data can be provided through Device >> +Tree. The node is a child node of the PCI controller. >> + >> +Required properties: >> +-compatible : Should be "qcom,ath10k" >> + >> +Optional properties: >> +- qcom,ath10k-calibration-data : calibration data as an array, the >> + length can vary between hw versions >> + > > Does the device always have a valid mac address in hardware? If not, > how about listing that as well using the mac-address property? Right now ath10k does not support that, but in the future we might want to add mac address as well. We need to do some testing with the firmware to make sure that we can safely change the "main" address from ath10k. And because of Virtual AP (mBSSID) feature we actually would need to provide multiple addresses, not just one. Maybe with addr_mask like struct wiphy has? * @perm_addr: permanent MAC address of this device * @addr_mask: If the device supports multiple MAC addresses by masking, * set this to a mask with variable bits set to 1, e.g. if the last * four bits are variable then set it to 00-00-00-00-00-0f. The actual * variable bits shall be determined by the interfaces added, with * interfaces not matching the mask being rejected to be brought up. /* permanent MAC address(es) */ u8 perm_addr[ETH_ALEN]; u8 addr_mask[ETH_ALEN];
On Friday 28 November 2014 11:54:39 Kalle Valo wrote: > > Right now ath10k does not support that, but in the future we might want > to add mac address as well. We need to do some testing with the firmware > to make sure that we can safely change the "main" address from ath10k. This is from Documentation/devicetree/bindings/net/ethernet.txt: - local-mac-address: array of 6 bytes, specifies the MAC address that was assigned to the network device; - mac-address: array of 6 bytes, specifies the MAC address that was last used by the boot program; should be used in cases where the MAC address assigned to the device by the boot program is different from the "local-mac-address" property; If the address is fixed, you might still be able to use the local-mac-address property to communicate the main address. Normally you only have to pass the mac address in DT if the device itself doesn't know the address. Do you know where the main address is stored? If it's always known to the card, we don't need to pass it, and if the card doesn't know it, I suspect it would be safe to change it. > And because of Virtual AP (mBSSID) feature we actually would need to > provide multiple addresses, not just one. Maybe with addr_mask like > struct wiphy has? > > * @perm_addr: permanent MAC address of this device > * @addr_mask: If the device supports multiple MAC addresses by masking, > * set this to a mask with variable bits set to 1, e.g. if the last > * four bits are variable then set it to 00-00-00-00-00-0f. The actual > * variable bits shall be determined by the interfaces added, with > * interfaces not matching the mask being rejected to be brought up. > > /* permanent MAC address(es) */ > u8 perm_addr[ETH_ALEN]; > u8 addr_mask[ETH_ALEN]; We don't have a common binding for this yet, I think drivers that do this at the moment just know how many addresses they are allowed to take. If the mask is generally considered useful, we could probably add that to the binding though. Arnd
Arnd Bergmann <arnd@arndb.de> writes: > On Friday 28 November 2014 11:54:39 Kalle Valo wrote: >> >> Right now ath10k does not support that, but in the future we might want >> to add mac address as well. We need to do some testing with the firmware >> to make sure that we can safely change the "main" address from ath10k. > > This is from Documentation/devicetree/bindings/net/ethernet.txt: > > - local-mac-address: array of 6 bytes, specifies the MAC address that was > assigned to the network device; > - mac-address: array of 6 bytes, specifies the MAC address that was last used by > the boot program; should be used in cases where the MAC address assigned to > the device by the boot program is different from the "local-mac-address" > property; > > If the address is fixed, you might still be able to use the local-mac-address > property to communicate the main address. Normally you only have to pass > the mac address in DT if the device itself doesn't know the address. Do you > know where the main address is stored? The ath10k main address is stored in the calibration data and the firmware delivers the address to ath10k. > If it's always known to the card, we don't need to pass it, and if the > card doesn't know it, I suspect it would be safe to change it. I suspect we can change the address afterwards, but I need to check to be sure. >> And because of Virtual AP (mBSSID) feature we actually would need to >> provide multiple addresses, not just one. Maybe with addr_mask like >> struct wiphy has? >> >> * @perm_addr: permanent MAC address of this device >> * @addr_mask: If the device supports multiple MAC addresses by masking, >> * set this to a mask with variable bits set to 1, e.g. if the last >> * four bits are variable then set it to 00-00-00-00-00-0f. The actual >> * variable bits shall be determined by the interfaces added, with >> * interfaces not matching the mask being rejected to be brought up. >> >> /* permanent MAC address(es) */ >> u8 perm_addr[ETH_ALEN]; >> u8 addr_mask[ETH_ALEN]; > > We don't have a common binding for this yet, I think drivers that do this > at the moment just know how many addresses they are allowed to take. > > If the mask is generally considered useful, we could probably add that to > the binding though. Currently ath10k supports up to 8 Virtual APs but the manufacturer can choose to allocate any number of MAC addresses (1-8). Something like addr_mask would be good way to inform ath10k what address range it has available.
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt new file mode 100644 index 000000000000..edefc26c6204 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt @@ -0,0 +1,30 @@ +* Qualcomm Atheros ath10k wireless devices + +For ath10k devices the calibration data can be provided through Device +Tree. The node is a child node of the PCI controller. + +Required properties: +-compatible : Should be "qcom,ath10k" + +Optional properties: +- qcom,ath10k-calibration-data : calibration data as an array, the + length can vary between hw versions + + +Example: + +pci { + pcie@0 { + reg = <0 0 0 0 0>; + #interrupt-cells = <1>; + #size-cells = <2>; + #address-cells = <3>; + device_type = "pci"; + + ath10k@0,0 { + reg = <0 0 0 0 0>; + device_type = "pci"; + qcom,ath10k-calibration-data = [ 01 02 03 ... ]; + }; + }; +};
Document how calibration data can be provided to ath10k via Device Tree. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> --- .../bindings/net/wireless/qcom,ath10k.txt | 30 ++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt