| Message ID | 20141124212706.10605.50148.stgit@i3820 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/24/2014 10:27 PM, Nikolay Nikolaev wrote: > This enables compilation of the eventfd feature on ARM. Hi Nikolay, why irqchip in the title? Best Regards Eric > > Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com> > --- > arch/arm/kvm/Kconfig | 1 + > arch/arm/kvm/Makefile | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig > index 466bd29..a4b0312 100644 > --- a/arch/arm/kvm/Kconfig > +++ b/arch/arm/kvm/Kconfig > @@ -20,6 +20,7 @@ config KVM > bool "Kernel-based Virtual Machine (KVM) support" > select PREEMPT_NOTIFIERS > select ANON_INODES > + select HAVE_KVM_EVENTFD > select HAVE_KVM_CPU_RELAX_INTERCEPT > select KVM_MMIO > select KVM_ARM_HOST > diff --git a/arch/arm/kvm/Makefile b/arch/arm/kvm/Makefile > index 443b8be..539c1a5 100644 > --- a/arch/arm/kvm/Makefile > +++ b/arch/arm/kvm/Makefile > @@ -15,7 +15,7 @@ AFLAGS_init.o := -Wa,-march=armv7-a$(plus_virt) > AFLAGS_interrupts.o := -Wa,-march=armv7-a$(plus_virt) > > KVM := ../../../virt/kvm > -kvm-arm-y = $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o > +kvm-arm-y = $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o $(KVM)/eventfd.o > > obj-y += kvm-arm.o init.o interrupts.o > obj-y += arm.o handle_exit.o guest.o mmu.o emulate.o reset.o >
On 2014/11/25 5:27, Nikolay Nikolaev wrote: > This enables compilation of the eventfd feature on ARM. > Only enable on ARM? I think we should enable it on ARM64 as well because the eventfd featrue is common for ARM32 and ARM64. Thanks, Shannon > Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com> > --- > arch/arm/kvm/Kconfig | 1 + > arch/arm/kvm/Makefile | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig > index 466bd29..a4b0312 100644 > --- a/arch/arm/kvm/Kconfig > +++ b/arch/arm/kvm/Kconfig > @@ -20,6 +20,7 @@ config KVM > bool "Kernel-based Virtual Machine (KVM) support" > select PREEMPT_NOTIFIERS > select ANON_INODES > + select HAVE_KVM_EVENTFD > select HAVE_KVM_CPU_RELAX_INTERCEPT > select KVM_MMIO > select KVM_ARM_HOST > diff --git a/arch/arm/kvm/Makefile b/arch/arm/kvm/Makefile > index 443b8be..539c1a5 100644 > --- a/arch/arm/kvm/Makefile > +++ b/arch/arm/kvm/Makefile > @@ -15,7 +15,7 @@ AFLAGS_init.o := -Wa,-march=armv7-a$(plus_virt) > AFLAGS_interrupts.o := -Wa,-march=armv7-a$(plus_virt) > > KVM := ../../../virt/kvm > -kvm-arm-y = $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o > +kvm-arm-y = $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o $(KVM)/eventfd.o > > obj-y += kvm-arm.o init.o interrupts.o > obj-y += arm.o handle_exit.o guest.o mmu.o emulate.o reset.o > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > >
Inidicate KVM in the subject please.
On Mon, Nov 24, 2014 at 11:27:06PM +0200, Nikolay Nikolaev wrote:
> This enables compilation of the eventfd feature on ARM.
does this enable anything else than the ioeventfd stuff so that
everything is in place to do this safely now?
-Christoffer
On Sat, Nov 29, 2014 at 9:18 AM, Shannon Zhao <zhaoshenglong@huawei.com> wrote: > > On 2014/11/25 5:27, Nikolay Nikolaev wrote: > > This enables compilation of the eventfd feature on ARM. > > > > Only enable on ARM? I think we should enable it on ARM64 as well because the eventfd featrue is common for ARM32 and ARM64. If course - thanks for pointing this out. regards, Nikolay Nikolaev > > Thanks, > Shannon > > > Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com> > > --- > > arch/arm/kvm/Kconfig | 1 + > > arch/arm/kvm/Makefile | 2 +- > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig > > index 466bd29..a4b0312 100644 > > --- a/arch/arm/kvm/Kconfig > > +++ b/arch/arm/kvm/Kconfig > > @@ -20,6 +20,7 @@ config KVM > > bool "Kernel-based Virtual Machine (KVM) support" > > select PREEMPT_NOTIFIERS > > select ANON_INODES > > + select HAVE_KVM_EVENTFD > > select HAVE_KVM_CPU_RELAX_INTERCEPT > > select KVM_MMIO > > select KVM_ARM_HOST > > diff --git a/arch/arm/kvm/Makefile b/arch/arm/kvm/Makefile > > index 443b8be..539c1a5 100644 > > --- a/arch/arm/kvm/Makefile > > +++ b/arch/arm/kvm/Makefile > > @@ -15,7 +15,7 @@ AFLAGS_init.o := -Wa,-march=armv7-a$(plus_virt) > > AFLAGS_interrupts.o := -Wa,-march=armv7-a$(plus_virt) > > > > KVM := ../../../virt/kvm > > -kvm-arm-y = $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o > > +kvm-arm-y = $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o $(KVM)/eventfd.o > > > > obj-y += kvm-arm.o init.o interrupts.o > > obj-y += arm.o handle_exit.o guest.o mmu.o emulate.o reset.o > > > > _______________________________________________ > > kvmarm mailing list > > kvmarm@lists.cs.columbia.edu > > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm > > > > >
On Sat, Nov 29, 2014 at 03:49:37PM +0200, Nikolay Nikolaev wrote: > On Sat, Nov 29, 2014 at 9:18 AM, Shannon Zhao <zhaoshenglong@huawei.com> wrote: > > > > On 2014/11/25 5:27, Nikolay Nikolaev wrote: > > > This enables compilation of the eventfd feature on ARM. > > > > > > > Only enable on ARM? I think we should enable it on ARM64 as well because the eventfd featrue is common for ARM32 and ARM64. > > If course - thanks for pointing this out. > Please remember testing if this breaks anything on arm64 :) -Christoffer
On Sat, Nov 29, 2014 at 1:29 PM, Christoffer Dall <christoffer.dall@linaro.org> wrote: > Inidicate KVM in the subject please. > > On Mon, Nov 24, 2014 at 11:27:06PM +0200, Nikolay Nikolaev wrote: >> This enables compilation of the eventfd feature on ARM. > > does this enable anything else than the ioeventfd stuff so that > everything is in place to do this safely now? Inspecting the eventfd.c I see that there is the IRQFD code conditionally compiled when CONFIG_HAVE_KVM_IRQFD is defined. I think this is enabled for arm/arm64 in Eric's IRQFD patcheries, so we should be safe now. regards, Nikolay Nikolaev > > -Christoffer
diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig index 466bd29..a4b0312 100644 --- a/arch/arm/kvm/Kconfig +++ b/arch/arm/kvm/Kconfig @@ -20,6 +20,7 @@ config KVM bool "Kernel-based Virtual Machine (KVM) support" select PREEMPT_NOTIFIERS select ANON_INODES + select HAVE_KVM_EVENTFD select HAVE_KVM_CPU_RELAX_INTERCEPT select KVM_MMIO select KVM_ARM_HOST diff --git a/arch/arm/kvm/Makefile b/arch/arm/kvm/Makefile index 443b8be..539c1a5 100644 --- a/arch/arm/kvm/Makefile +++ b/arch/arm/kvm/Makefile @@ -15,7 +15,7 @@ AFLAGS_init.o := -Wa,-march=armv7-a$(plus_virt) AFLAGS_interrupts.o := -Wa,-march=armv7-a$(plus_virt) KVM := ../../../virt/kvm -kvm-arm-y = $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o +kvm-arm-y = $(KVM)/kvm_main.o $(KVM)/coalesced_mmio.o $(KVM)/eventfd.o obj-y += kvm-arm.o init.o interrupts.o obj-y += arm.o handle_exit.o guest.o mmu.o emulate.o reset.o
This enables compilation of the eventfd feature on ARM. Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com> --- arch/arm/kvm/Kconfig | 1 + arch/arm/kvm/Makefile | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)