[1/1] SPI-txx9: Deletion of an unnecessary check before the function call "clk_disable"

Commit Message

SF Markus Elfring Nov. 29, 2014, 5:40 p.m. UTC

From: Markus Elfring <[e-mail]>
Date: Sat, 29 Nov 2014 18:34:20 +0100

The clk_disable() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[e-mail]>
---
 drivers/spi/spi-txx9.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Mark Brown Dec. 1, 2014, 7:25 p.m. UTC | #1

On Sat, Nov 29, 2014 at 06:40:28PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <[e-mail]>
> Date: Sat, 29 Nov 2014 18:34:20 +0100
> 
> The clk_disable() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.

Applied, but please do try to use subject lines matching the style for
the subsystem.

Patch

diff --git a/drivers/spi/spi-txx9.c b/drivers/spi/spi-txx9.c
index 0da7c67..9190124 100644
--- a/drivers/spi/spi-txx9.c
+++ b/drivers/spi/spi-txx9.c
@@ -402,8 +402,7 @@  exit_busy:
 exit:
 	if (c->workqueue)
 		destroy_workqueue(c->workqueue);
-	if (c->clk)
-		clk_disable(c->clk);
+	clk_disable(c->clk);
 	spi_master_put(master);
 	return ret;
 }