diff mbox

[05/24] compatfd is included before, and it is compiled unconditionally

Message ID 6e46fe952ba8d1896e3cab5b24232828d3f827a9.1253272938.git.quintela@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Juan Quintela Sept. 18, 2009, 11:41 a.m. UTC
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 Makefile |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

Comments

Christoph Hellwig Sept. 22, 2009, 1:19 p.m. UTC | #1
Btw, what's the state of getting compatfd upstream?  It's a pretty
annoying difference between qemu upstream and qemu-kvm.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Juan Quintela Sept. 22, 2009, 1:25 p.m. UTC | #2
Christoph Hellwig <hch@infradead.org> wrote:
> Btw, what's the state of getting compatfd upstream?  It's a pretty
> annoying difference between qemu upstream and qemu-kvm.

I haven't tried.  I can try to send a patch.  Do you have any use case
that will help the cause?

Later, Juan.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Christoph Hellwig Sept. 22, 2009, 1:34 p.m. UTC | #3
On Tue, Sep 22, 2009 at 03:25:13PM +0200, Juan Quintela wrote:
> Christoph Hellwig <hch@infradead.org> wrote:
> > Btw, what's the state of getting compatfd upstream?  It's a pretty
> > annoying difference between qemu upstream and qemu-kvm.
> 
> I haven't tried.  I can try to send a patch.  Do you have any use case
> that will help the cause?

Well, the eventfd compat is used in the thread pool AIO code.  I don't
know what difference it makes, but I really hate this code beeing
different in both trees.  I want to see compatfd used either in both or
none.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Makefile b/Makefile
index 6a9ca7c..88b39bd 100644
--- a/Makefile
+++ b/Makefile
@@ -78,10 +78,6 @@  block-nested-$(CONFIG_CURL) += curl.o

 block-obj-y +=  $(addprefix block/, $(block-nested-y))

-ifdef CONFIG_AIO
-block-obj-y += compatfd.o
-endif
-
 ######################################################################
 # libqemu_common.a: Target independent part of system emulation. The
 # long term path is to suppress *all* target specific code in case of