| Message ID | 1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Dec 7, 2014 at 8:20 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > Replace a misspelled function name by %s and then __func__. > > s3c2410 is the name of the file, but using the exact function name should > make it easier to connect the error message to the code. > > This was done using Coccinelle, including the use of Levenshtein distance, > as proposed by Rasmus Villemoes. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > The semantic patch is difficult to summarize, but is available in the cover > letter of this patch series. > > drivers/mtd/nand/s3c2410.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c > index 35aef5e..0a9c41f 100644 > --- a/drivers/mtd/nand/s3c2410.c > +++ b/drivers/mtd/nand/s3c2410.c > @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) > > cpu_type = platform_get_device_id(pdev)->driver_data; > > - pr_debug("s3c2410_nand_probe(%p)\n", pdev); > + pr_debug("%s(%p)\n", __func__, pdev); I think we can drop the line completely. We have ftrace to trace function calls...
> > diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c > > index 35aef5e..0a9c41f 100644 > > --- a/drivers/mtd/nand/s3c2410.c > > +++ b/drivers/mtd/nand/s3c2410.c > > @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) > > > > cpu_type = platform_get_device_id(pdev)->driver_data; > > > > - pr_debug("s3c2410_nand_probe(%p)\n", pdev); > > + pr_debug("%s(%p)\n", __func__, pdev); > > I think we can drop the line completely. > We have ftrace to trace function calls... Should the "initialised ok" at the end of the function be remove as well? Will it be confusing if this cleanup is done in this function, but not in others where it may be useful? Perhaps s3c2410_nand_update_chip, for example? julia
Am 08.12.2014 um 08:11 schrieb Julia Lawall: >>> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c >>> index 35aef5e..0a9c41f 100644 >>> --- a/drivers/mtd/nand/s3c2410.c >>> +++ b/drivers/mtd/nand/s3c2410.c >>> @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) >>> >>> cpu_type = platform_get_device_id(pdev)->driver_data; >>> >>> - pr_debug("s3c2410_nand_probe(%p)\n", pdev); >>> + pr_debug("%s(%p)\n", __func__, pdev); >> >> I think we can drop the line completely. >> We have ftrace to trace function calls... > > Should the "initialised ok" at the end of the function be remove as well? > > Will it be confusing if this cleanup is done in this function, but not in > others where it may be useful? Perhaps s3c2410_nand_update_chip, for > example? Hmm, this driver seems to have a lot of debugging printks(). IMHO we can remove them. Let's see what Brain says. Thanks, //richard
diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c index 35aef5e..0a9c41f 100644 --- a/drivers/mtd/nand/s3c2410.c +++ b/drivers/mtd/nand/s3c2410.c @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) cpu_type = platform_get_device_id(pdev)->driver_data; - pr_debug("s3c2410_nand_probe(%p)\n", pdev); + pr_debug("%s(%p)\n", __func__, pdev); info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); if (info == NULL) {
Replace a misspelled function name by %s and then __func__. s3c2410 is the name of the file, but using the exact function name should make it easier to connect the error message to the code. This was done using Coccinelle, including the use of Levenshtein distance, as proposed by Rasmus Villemoes. Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- The semantic patch is difficult to summarize, but is available in the cover letter of this patch series. drivers/mtd/nand/s3c2410.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)