| Message ID | 5384843.KGcHOMgQLi@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
On Wed, Nov 05, 2014 at 01:48:48AM +0300, Sergei Shtylyov wrote: > There is a typo ("prove" instead of "probe") in the error message printed when > the platform initialization fails. Replace that word with more fitting "init". > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> this actually goes through me, I'll take it in a bit.
Hello. On 11/05/2014 01:53 AM, Felipe Balbi wrote: >> There is a typo ("prove" instead of "probe") in the error message printed when >> the platform initialization fails. Replace that word with more fitting "init". >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > this actually goes through me, I'll take it in a bit. Er, OK. Could you update MAINTAINERS? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Nov 05, 2014 at 01:55:17AM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/05/2014 01:53 AM, Felipe Balbi wrote: > > >>There is a typo ("prove" instead of "probe") in the error message printed when > >>the platform initialization fails. Replace that word with more fitting "init". > > >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > >this actually goes through me, I'll take it in a bit. > > Er, OK. Could you update MAINTAINERS? there is no entry for renesas driver in MAINTAINERS. Shimoda-san, care to send a patch adding yourself or Morimoto-san as maintainers for Renesas driver and pointing to my tree in kernel.org ? Thank you
Hello. On 11/05/2014 01:53 AM, Felipe Balbi wrote: >> There is a typo ("prove" instead of "probe") in the error message printed when >> the platform initialization fails. Replace that word with more fitting "init". >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > this actually goes through me, I'll take it in a bit. Felipe, I'm not seeing this patch anywhere in your tree. :-( WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, I'm very sorry for the delayed response. > -----Original Message----- > From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-owner@vger.kernel.org] On Behalf Of Felipe Balbi > Sent: Wednesday, November 05, 2014 8:01 AM > > Hi, > > On Wed, Nov 05, 2014 at 01:55:17AM +0300, Sergei Shtylyov wrote: > > Hello. > > > > On 11/05/2014 01:53 AM, Felipe Balbi wrote: > > > > >>There is a typo ("prove" instead of "probe") in the error message printed when > > >>the platform initialization fails. Replace that word with more fitting "init". > > > > >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > > >this actually goes through me, I'll take it in a bit. > > > > Er, OK. Could you update MAINTAINERS? > > there is no entry for renesas driver in MAINTAINERS. > > Shimoda-san, care to send a patch adding yourself or Morimoto-san as > maintainers for Renesas driver and pointing to my tree in kernel.org ? I would like to move the renesas_usbhs driver to drivers/usb/gadget/udc somehow. Because the driver is almost used for a gadget driver. The driver has a host driver support now. But, it is not used recently. After that, this MAINTAINERS issue becomes clear, I think. Felipe-san and Sergei-san, what do you think? Best regards, Yoshihiro Shimoda > Thank you > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 12/18/2014 4:46 AM, yoshihiro shimoda wrote: [...] >>>>> There is a typo ("prove" instead of "probe") in the error message printed when >>>>> the platform initialization fails. Replace that word with more fitting "init". >>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> this actually goes through me, I'll take it in a bit. >>> Er, OK. Could you update MAINTAINERS? >> there is no entry for renesas driver in MAINTAINERS. >> Shimoda-san, care to send a patch adding yourself or Morimoto-san as >> maintainers for Renesas driver and pointing to my tree in kernel.org ? > I would like to move the renesas_usbhs driver to drivers/usb/gadget/udc somehow. > Because the driver is almost used for a gadget driver. > The driver has a host driver support now. But, it is not used recently. > After that, this MAINTAINERS issue becomes clear, I think. > Felipe-san and Sergei-san, what do you think? I'm against such move. > Best regards, > Yoshihiro Shimoda WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, > -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > Sent: Thursday, December 18, 2014 8:32 PM > > Hello. > > On 12/18/2014 4:46 AM, yoshihiro shimoda wrote: > > [...] > > >>>>> There is a typo ("prove" instead of "probe") in the error message printed when > >>>>> the platform initialization fails. Replace that word with more fitting "init". > > >>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > >>>> this actually goes through me, I'll take it in a bit. > > >>> Er, OK. Could you update MAINTAINERS? > > >> there is no entry for renesas driver in MAINTAINERS. > > >> Shimoda-san, care to send a patch adding yourself or Morimoto-san as > >> maintainers for Renesas driver and pointing to my tree in kernel.org ? > > > I would like to move the renesas_usbhs driver to drivers/usb/gadget/udc somehow. > > Because the driver is almost used for a gadget driver. > > The driver has a host driver support now. But, it is not used recently. > > > After that, this MAINTAINERS issue becomes clear, I think. > > Felipe-san and Sergei-san, what do you think? > > I'm against such move. Thank you for the reply. But, I would like to know why you are against such move. Best regards, Yoshihiro Shimoda > > Best regards, > > Yoshihiro Shimoda > > WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 12/19/2014 4:33 AM, yoshihiro shimoda wrote: [...] >>>>>>> There is a typo ("prove" instead of "probe") in the error message printed when >>>>>>> the platform initialization fails. Replace that word with more fitting "init". >>>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>>>> this actually goes through me, I'll take it in a bit. >>>>> Er, OK. Could you update MAINTAINERS? >>>> there is no entry for renesas driver in MAINTAINERS. >>>> Shimoda-san, care to send a patch adding yourself or Morimoto-san as >>>> maintainers for Renesas driver and pointing to my tree in kernel.org ? >>> I would like to move the renesas_usbhs driver to drivers/usb/gadget/udc somehow. >>> Because the driver is almost used for a gadget driver. >>> The driver has a host driver support now. But, it is not used recently. >>> After that, this MAINTAINERS issue becomes clear, I think. >>> Felipe-san and Sergei-san, what do you think? >> I'm against such move. > Thank you for the reply. But, I would like to know why you are against such move. Because we still need the host mode; RZ/A1H (R7S72100) SoC should need it soon), and bi-modal USBHS hardware is better placed in its own directory. > Best regards, > Yoshihiro Shimoda WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 12, 2014 at 10:45:26PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/05/2014 01:53 AM, Felipe Balbi wrote: > > >>There is a typo ("prove" instead of "probe") in the error message printed when > >>the platform initialization fails. Replace that word with more fitting "init". > > >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > >this actually goes through me, I'll take it in a bit. > > Felipe, I'm not seeing this patch anywhere in your tree. :-( it's now on testing/next
On Fri, Dec 19, 2014 at 03:46:41PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/19/2014 4:33 AM, yoshihiro shimoda wrote: > > [...] > > >>>>>>>There is a typo ("prove" instead of "probe") in the error message printed when > >>>>>>>the platform initialization fails. Replace that word with more fitting "init". > > >>>>>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > >>>>>>this actually goes through me, I'll take it in a bit. > > >>>>> Er, OK. Could you update MAINTAINERS? > > >>>>there is no entry for renesas driver in MAINTAINERS. > > >>>>Shimoda-san, care to send a patch adding yourself or Morimoto-san as > >>>>maintainers for Renesas driver and pointing to my tree in kernel.org ? > > >>>I would like to move the renesas_usbhs driver to drivers/usb/gadget/udc somehow. > >>>Because the driver is almost used for a gadget driver. > >>>The driver has a host driver support now. But, it is not used recently. > > >>>After that, this MAINTAINERS issue becomes clear, I think. > >>>Felipe-san and Sergei-san, what do you think? > > >> I'm against such move. > > >Thank you for the reply. But, I would like to know why you are against such move. > > Because we still need the host mode; RZ/A1H (R7S72100) SoC should need it > soon), and bi-modal USBHS hardware is better placed in its own directory. yeah, I'll agree with Sergei here. All other dual role IPs have their own directories (musb, dwc3, dwc2, isp1760, chipidea...).
Hello. On 12/23/2014 10:17 PM, Felipe Balbi wrote: [...] >>>>>>>>> There is a typo ("prove" instead of "probe") in the error message printed when >>>>>>>>> the platform initialization fails. Replace that word with more fitting "init". >>>>>>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>>>>>> this actually goes through me, I'll take it in a bit. >>>>>>> Er, OK. Could you update MAINTAINERS? >>>>>> there is no entry for renesas driver in MAINTAINERS. >>>>>> Shimoda-san, care to send a patch adding yourself or Morimoto-san as >>>>>> maintainers for Renesas driver and pointing to my tree in kernel.org ? >>>>> I would like to move the renesas_usbhs driver to drivers/usb/gadget/udc somehow. >>>>> Because the driver is almost used for a gadget driver. >>>>> The driver has a host driver support now. But, it is not used recently. >>>>> After that, this MAINTAINERS issue becomes clear, I think. >>>>> Felipe-san and Sergei-san, what do you think? >>>> I'm against such move. >>> Thank you for the reply. But, I would like to know why you are against such move. >> Because we still need the host mode; RZ/A1H (R7S72100) SoC should need it >> soon), and bi-modal USBHS hardware is better placed in its own directory. > yeah, I'll agree with Sergei here. All other dual role IPs have their Thanks. :-) > own directories (musb, dwc3, dwc2, isp1760, chipidea...). However, I'm only seeing ISP1760 files in drivers/usb/host/... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 23, 2014 at 10:41:49PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/23/2014 10:17 PM, Felipe Balbi wrote: > > [...] > > >>>>>>>>>There is a typo ("prove" instead of "probe") in the error message printed when > >>>>>>>>>the platform initialization fails. Replace that word with more fitting "init". > > >>>>>>>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > >>>>>>>>this actually goes through me, I'll take it in a bit. > > >>>>>>> Er, OK. Could you update MAINTAINERS? > > >>>>>>there is no entry for renesas driver in MAINTAINERS. > > >>>>>>Shimoda-san, care to send a patch adding yourself or Morimoto-san as > >>>>>>maintainers for Renesas driver and pointing to my tree in kernel.org ? > > >>>>>I would like to move the renesas_usbhs driver to drivers/usb/gadget/udc somehow. > >>>>>Because the driver is almost used for a gadget driver. > >>>>>The driver has a host driver support now. But, it is not used recently. > > >>>>>After that, this MAINTAINERS issue becomes clear, I think. > >>>>>Felipe-san and Sergei-san, what do you think? > > >>>> I'm against such move. > > >>>Thank you for the reply. But, I would like to know why you are against such move. > > >> Because we still need the host mode; RZ/A1H (R7S72100) SoC should need it > >>soon), and bi-modal USBHS hardware is better placed in its own directory. > > >yeah, I'll agree with Sergei here. All other dual role IPs have their > > Thanks. :-) > > >own directories (musb, dwc3, dwc2, isp1760, chipidea...). > > However, I'm only seeing ISP1760 files in drivers/usb/host/... There are patches pending :-) But now that I look at it, Laurent added peripheral support but kept the thing under drivers/usb/host. I asked him to move it out from there.
Hi Felipe-san, Sergei-san, > -----Original Message----- > From: Felipe Balbi [mailto:balbi@ti.com] > Sent: Wednesday, December 24, 2014 4:17 AM > > On Fri, Dec 19, 2014 at 03:46:41PM +0300, Sergei Shtylyov wrote: > > Hello. > > > > On 12/19/2014 4:33 AM, yoshihiro shimoda wrote: > > > > [...] > > > > >>>>>>>There is a typo ("prove" instead of "probe") in the error message printed when > > >>>>>>>the platform initialization fails. Replace that word with more fitting "init". > > > > >>>>>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > > >>>>>>this actually goes through me, I'll take it in a bit. > > > > >>>>> Er, OK. Could you update MAINTAINERS? > > > > >>>>there is no entry for renesas driver in MAINTAINERS. > > > > >>>>Shimoda-san, care to send a patch adding yourself or Morimoto-san as > > >>>>maintainers for Renesas driver and pointing to my tree in kernel.org ? > > > > >>>I would like to move the renesas_usbhs driver to drivers/usb/gadget/udc somehow. > > >>>Because the driver is almost used for a gadget driver. > > >>>The driver has a host driver support now. But, it is not used recently. > > > > >>>After that, this MAINTAINERS issue becomes clear, I think. > > >>>Felipe-san and Sergei-san, what do you think? > > > > >> I'm against such move. > > > > >Thank you for the reply. But, I would like to know why you are against such move. > > > > Because we still need the host mode; RZ/A1H (R7S72100) SoC should need it > > soon), and bi-modal USBHS hardware is better placed in its own directory. > > yeah, I'll agree with Sergei here. All other dual role IPs have their > own directories (musb, dwc3, dwc2, isp1760, chipidea...). Thank you for the reply. I also agree with you. By the way, about a renesas_usbhs maintainer, I don't know clearly. If I do as a renesas_usbhs maintainer: - what should I do as the maintainer? - I think I should check patches of renesas_usbhs - And, do I just return ACK or NACK to the patches? Best regards, Yoshihiro Shimoda > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Shimoda-san, On Wed, Dec 24, 2014 at 11:02 AM, yoshihiro shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: >> > >>>>> Er, OK. Could you update MAINTAINERS? >> > >>>>there is no entry for renesas driver in MAINTAINERS. >> > >>>>Shimoda-san, care to send a patch adding yourself or Morimoto-san as >> > >>>>maintainers for Renesas driver and pointing to my tree in kernel.org ? > By the way, about a renesas_usbhs maintainer, I don't know clearly. > If I do as a renesas_usbhs maintainer: > - what should I do as the maintainer? > - I think I should check patches of renesas_usbhs > - And, do I just return ACK or NACK to the patches? As a maintainer, you review all patches for renesas_usbhs, and of these patches will have to go through you. There are three ways to achieve that: 1. You collect all accepted patches, and forward them to GregKH with your Signed-off-by added, 2. You collect all accepted ls -lpatches, publish them in a git tree, and ask GregKH to pull a branch or tag from your git tree, 3. You ack all accepted patches, so GregKH knows which patches to apply. Which way to choose depends on the volume of patches. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
SGkgR3JlZXQtc2FuLA0KDQo+IA0KPiBIaSBTaGltb2RhLXNhbiwNCj4gDQo+IE9uIFdlZCwgRGVj IDI0LCAyMDE0IGF0IDExOjAyIEFNLCB5b3NoaWhpcm8gc2hpbW9kYQ0KPiA8eW9zaGloaXJvLnNo aW1vZGEudWhAcmVuZXNhcy5jb20+IHdyb3RlOg0KPiA+PiA+ID4+Pj4+ICAgICBFciwgT0suIENv dWxkIHlvdSB1cGRhdGUgTUFJTlRBSU5FUlM/DQo+ID4+ID4gPj4+PnRoZXJlIGlzIG5vIGVudHJ5 IGZvciByZW5lc2FzIGRyaXZlciBpbiBNQUlOVEFJTkVSUy4NCj4gPj4gPiA+Pj4+U2hpbW9kYS1z YW4sIGNhcmUgdG8gc2VuZCBhIHBhdGNoIGFkZGluZyB5b3Vyc2VsZiBvciBNb3JpbW90by1zYW4g YXMNCj4gPj4gPiA+Pj4+bWFpbnRhaW5lcnMgZm9yIFJlbmVzYXMgZHJpdmVyIGFuZCBwb2ludGlu ZyB0byBteSB0cmVlIGluIGtlcm5lbC5vcmcgPw0KPiANCj4gPiBCeSB0aGUgd2F5LCBhYm91dCBh IHJlbmVzYXNfdXNiaHMgbWFpbnRhaW5lciwgSSBkb24ndCBrbm93IGNsZWFybHkuDQo+ID4gSWYg SSBkbyBhcyBhIHJlbmVzYXNfdXNiaHMgbWFpbnRhaW5lcjoNCj4gPiAtIHdoYXQgc2hvdWxkIEkg ZG8gYXMgdGhlIG1haW50YWluZXI/DQo+ID4gIC0gSSB0aGluayBJIHNob3VsZCBjaGVjayBwYXRj aGVzIG9mIHJlbmVzYXNfdXNiaHMNCj4gPiAgLSBBbmQsIGRvIEkganVzdCByZXR1cm4gIEFDSyBv ciBOQUNLIHRvIHRoZSBwYXRjaGVzPw0KPiANCj4gQXMgYSBtYWludGFpbmVyLCB5b3UgcmV2aWV3 IGFsbCBwYXRjaGVzIGZvciByZW5lc2FzX3VzYmhzLCBhbmQgb2YgdGhlc2UgcGF0Y2hlcw0KPiB3 aWxsIGhhdmUgdG8gZ28gdGhyb3VnaCB5b3UuDQo+IFRoZXJlIGFyZSB0aHJlZSB3YXlzIHRvIGFj aGlldmUgdGhhdDoNCj4gICAxLiBZb3UgY29sbGVjdCBhbGwgYWNjZXB0ZWQgcGF0Y2hlcywgYW5k IGZvcndhcmQgdGhlbSB0byBHcmVnS0ggd2l0aCB5b3VyDQo+ICAgICAgU2lnbmVkLW9mZi1ieSBh ZGRlZCwNCj4gICAyLiBZb3UgY29sbGVjdCBhbGwgYWNjZXB0ZWQgbHMgLWxwYXRjaGVzLCBwdWJs aXNoIHRoZW0gaW4gYSBnaXQgdHJlZSwgYW5kDQo+ICAgICAgYXNrIEdyZWdLSCB0byBwdWxsIGEg YnJhbmNoIG9yIHRhZyBmcm9tIHlvdXIgZ2l0IHRyZWUsDQo+ICAgMy4gWW91IGFjayBhbGwgYWNj ZXB0ZWQgcGF0Y2hlcywgc28gR3JlZ0tIIGtub3dzIHdoaWNoIHBhdGNoZXMgdG8gYXBwbHkuDQo+ IA0KPiBXaGljaCB3YXkgdG8gY2hvb3NlIGRlcGVuZHMgb24gdGhlIHZvbHVtZSBvZiBwYXRjaGVz Lg0KDQpUaGFuayB5b3UgdmVyeSBtdWNoIGZvciB0aGUgcmVwbHkhDQpJIHVuZGVyc3Rvb2Qgd2hh dCBhIG1haW50YWluZXIgc2hvdWxkIGRvLg0KU28sIEkgd2lsbCBzdWJtaXQgYSBwYXRjaCBmb3Ig TUFJTlRBSU5FUlMgZmlsZS4NCg0KQmVzdCByZWdhcmRzLA0KWW9zaGloaXJvIFNoaW1vZGENCg0K PiBHcntvZXRqZSxlZXRpbmd9cywNCj4gDQo+ICAgICAgICAgICAgICAgICAgICAgICAgIEdlZXJ0 DQo+IA0KPiAtLQ0KPiBHZWVydCBVeXR0ZXJob2V2ZW4gLS0gVGhlcmUncyBsb3RzIG9mIExpbnV4 IGJleW9uZCBpYTMyIC0tIGdlZXJ0QGxpbnV4LW02OGsub3JnDQo+IA0KPiBJbiBwZXJzb25hbCBj b252ZXJzYXRpb25zIHdpdGggdGVjaG5pY2FsIHBlb3BsZSwgSSBjYWxsIG15c2VsZiBhIGhhY2tl ci4gQnV0DQo+IHdoZW4gSSdtIHRhbGtpbmcgdG8gam91cm5hbGlzdHMgSSBqdXN0IHNheSAicHJv Z3JhbW1lciIgb3Igc29tZXRoaW5nIGxpa2UgdGhhdC4NCj4gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAtLSBMaW51cyBUb3J2YWxkcw0K -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: usb/drivers/usb/renesas_usbhs/common.c =================================================================== --- usb.orig/drivers/usb/renesas_usbhs/common.c +++ usb/drivers/usb/renesas_usbhs/common.c @@ -615,7 +615,7 @@ static int usbhs_probe(struct platform_d */ ret = usbhs_platform_call(priv, hardware_init, pdev); if (ret < 0) { - dev_err(&pdev->dev, "platform prove failed.\n"); + dev_err(&pdev->dev, "platform init failed.\n"); goto probe_end_mod_exit; }
There is a typo ("prove" instead of "probe") in the error message printed when the platform initialization fails. Replace that word with more fitting "init". Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- The patch is against the 'usb-linus' branch of Greg KH's 'usb.git' repo. Changes in varsion 2: - refreshed the patch. drivers/usb/renesas_usbhs/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html