| Message ID | 1418651737-10016-1-git-send-email-geert@linux-m68k.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, 15 Dec 2014 14:55:37 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m: > > drivers/built-in.o: In function `mcam_v4l_open': > mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops' > mcam-core.c:(.text+0x1c2eb0): undefined reference to `vb2_dma_sg_init_ctx' > drivers/built-in.o: In function `mcam_v4l_release': > mcam-core.c:(.text+0x1c34bf): undefined reference to `vb2_dma_sg_cleanup_ctx' I've been mildly resistant to this because I've never figured out how such a configuration can come about. The Cafe chip only appeared in the OLPC XO-1 and cannot even come close to doing S/G I/O. So this patch robs a bit of memory for no use on a platform that can ill afford it. OTOH, the number of people building contemporary kernels for the XO-1 has got to be pretty small. So, in the interest of mollifying randconfig users out there, you can add my: Acked-by: Jonathan Corbet <corbet@lwn.net> jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jon, On Mon, Dec 15, 2014 at 3:04 PM, Jonathan Corbet <corbet@lwn.net> wrote: > On Mon, 15 Dec 2014 14:55:37 +0100 > Geert Uytterhoeven <geert@linux-m68k.org> wrote: > >> If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m: >> >> drivers/built-in.o: In function `mcam_v4l_open': >> mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops' >> mcam-core.c:(.text+0x1c2eb0): undefined reference to `vb2_dma_sg_init_ctx' >> drivers/built-in.o: In function `mcam_v4l_release': >> mcam-core.c:(.text+0x1c34bf): undefined reference to `vb2_dma_sg_cleanup_ctx' > > I've been mildly resistant to this because I've never figured out how > such a configuration can come about. The Cafe chip only appeared in the > OLPC XO-1 and cannot even come close to doing S/G I/O. So this patch > robs a bit of memory for no use on a platform that can ill afford it. If the driver cannot do SG, perhaps this block should be removed from drivers/media/platform/marvell-ccic/mcam-core.h? #if IS_ENABLED(CONFIG_VIDEOBUF2_DMA_SG) #define MCAM_MODE_DMA_SG 1 #endif Oh, this seems to be a reason for the breakage, too: IS_ENABLED() evaluates to true for modular options... > OTOH, the number of people building contemporary kernels for the XO-1 has > got to be pretty small. So, in the interest of mollifying randconfig > users out there, you can add my: > > Acked-by: Jonathan Corbet <corbet@lwn.net> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 15 Dec 2014 15:10:38 +0100 Geert Uytterhoeven <geert@linux-m68k.org> wrote: > If the driver cannot do SG, perhaps this block should be removed from > drivers/media/platform/marvell-ccic/mcam-core.h? > > #if IS_ENABLED(CONFIG_VIDEOBUF2_DMA_SG) > #define MCAM_MODE_DMA_SG 1 > #endif Other drivers using the Marvell core can do S/G, though, so that option needs to remain. Applying your patch is almost certainly the most straightforward solution at this point. Thanks, jon -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/marvell-ccic/Kconfig b/drivers/media/platform/marvell-ccic/Kconfig index 6265d36adcebcb89..3d166568bd6955bd 100644 --- a/drivers/media/platform/marvell-ccic/Kconfig +++ b/drivers/media/platform/marvell-ccic/Kconfig @@ -5,6 +5,7 @@ config VIDEO_CAFE_CCIC select VIDEO_OV7670 select VIDEOBUF2_VMALLOC select VIDEOBUF2_DMA_CONTIG + select VIDEOBUF2_DMA_SG ---help--- This is a video4linux2 driver for the Marvell 88ALP01 integrated CMOS camera controller. This is the controller found on first-
If VIDEO_CAFE_CCIC=y, but VIDEOBUF2_DMA_SG=m: drivers/built-in.o: In function `mcam_v4l_open': mcam-core.c:(.text+0x1c2e81): undefined reference to `vb2_dma_sg_memops' mcam-core.c:(.text+0x1c2eb0): undefined reference to `vb2_dma_sg_init_ctx' drivers/built-in.o: In function `mcam_v4l_release': mcam-core.c:(.text+0x1c34bf): undefined reference to `vb2_dma_sg_cleanup_ctx' Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> --- This is a resend of a patch from 2013-09-30. It's still valid. drivers/media/platform/marvell-ccic/Kconfig | 1 + 1 file changed, 1 insertion(+)