| Message ID | 1420215089-2093-1-git-send-email-javier.martinez@collabora.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On pi?, 2015-01-02 at 17:11 +0100, Javier Martinez Canillas wrote: > Many Exynos devices have a display panel. Most of them just have > a simple panel while others have more complex configurations that > requires an embedded DisplayPort (eDP) to LVDS bridges. > > This patch enables the following features to be built in the kernel > image to support both setups: > > - Direct Rendering Manager (DRM) > - DRM bridge registration and lookup framework > - Parade ps8622/ps8625 eDP/LVDS bridge > - NXP ptn3460 eDP/LVDS bridge > - Exynos Fully Interactive Mobile Display controller (FIMD) > - Panel registration and lookup framework > - Simple panels > - Backlight & LCD device support > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Tested-by: Kevin Hilman <khilman@linaro.org> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com> > --- > > Hello Kukjin, > > You dropped this patch since exynos drm was causing boot hangs on some > platforms but the fix for that issue is already in linux-next (commit: > f1e9203 clk: samsung: Fix Exynos 5420 pinctrl setup and clock disable > failure due to domain being gated) so I think it makes sense to enable > the display options again. I think these issues were unrelated to each other. DRM was disabled because of infinite deferred probing of DRM components. I saw Inki was sending some patches for it but I am not sure if they were merged. Best regards, Krzysztof > > NOTE: Display panel is still not working since patch "arm: dts: Exynos5: > Use pmu_system_controller phandle for dp phy" is needed [0] but I think > we should enable display options to catch the regressions easier. > > Best regards, > Javier > > [0]: https://lkml.org/lkml/2014/11/24/10 > > arch/arm/configs/exynos_defconfig | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 22beed3..27cdd52 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -111,11 +111,26 @@ CONFIG_REGULATOR_S2MPA01=y > CONFIG_REGULATOR_S2MPS11=y > CONFIG_REGULATOR_S5M8767=y > CONFIG_REGULATOR_TPS65090=y > +CONFIG_DRM=y > +CONFIG_DRM_BRIDGE=y > +CONFIG_DRM_PTN3460=y > +CONFIG_DRM_PS8622=y > +CONFIG_DRM_EXYNOS=y > +CONFIG_DRM_EXYNOS_FIMD=y > +CONFIG_DRM_EXYNOS_DP=y > +CONFIG_DRM_PANEL=y > +CONFIG_DRM_PANEL_SIMPLE=y > CONFIG_FB=y > CONFIG_FB_MODE_HELPERS=y > CONFIG_FB_SIMPLE=y > CONFIG_EXYNOS_VIDEO=y > CONFIG_EXYNOS_MIPI_DSI=y > +CONFIG_BACKLIGHT_LCD_SUPPORT=y > +CONFIG_LCD_CLASS_DEVICE=y > +CONFIG_LCD_PLATFORM=y > +CONFIG_BACKLIGHT_CLASS_DEVICE=y > +CONFIG_BACKLIGHT_GENERIC=y > +CONFIG_BACKLIGHT_PWM=y > CONFIG_FRAMEBUFFER_CONSOLE=y > CONFIG_FONTS=y > CONFIG_FONT_7x14=y
Hello Krzysztof, >> Hello Kukjin, >> >> You dropped this patch since exynos drm was causing boot hangs on some >> platforms but the fix for that issue is already in linux-next (commit: >> f1e9203 clk: samsung: Fix Exynos 5420 pinctrl setup and clock disable >> failure due to domain being gated) so I think it makes sense to enable >> the display options again. > > I think these issues were unrelated to each other. DRM was disabled > because of infinite deferred probing of DRM components. I saw Inki was > sending some patches for it but I am not sure if they were merged. > Ups, you are completely right and it was my bad for pasting the wrong commit fixing the boot hang when DRM was enabled, I actually meant commit: ("820687be drm/exynos: move Exynos platform drivers registration to init") which also landed in v3.19-rc1. Sorry for the confusion. > Best regards, > Krzysztof Best regards, Javier
Javier Martinez Canillas wrote: > > Many Exynos devices have a display panel. Most of them just have > a simple panel while others have more complex configurations that > requires an embedded DisplayPort (eDP) to LVDS bridges. > > This patch enables the following features to be built in the kernel > image to support both setups: > > - Direct Rendering Manager (DRM) > - DRM bridge registration and lookup framework > - Parade ps8622/ps8625 eDP/LVDS bridge > - NXP ptn3460 eDP/LVDS bridge > - Exynos Fully Interactive Mobile Display controller (FIMD) > - Panel registration and lookup framework > - Simple panels > - Backlight & LCD device support > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > Tested-by: Kevin Hilman <khilman@linaro.org> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com> > --- > > Hello Kukjin, > Hi Javier, Happy new year :) > You dropped this patch since exynos drm was causing boot hangs on some > platforms but the fix for that issue is already in linux-next (commit: > f1e9203 clk: samsung: Fix Exynos 5420 pinctrl setup and clock disable > failure due to domain being gated) so I think it makes sense to enable > the display options again. > > NOTE: Display panel is still not working since patch "arm: dts: Exynos5: > Use pmu_system_controller phandle for dp phy" is needed [0] but I think > we should enable display options to catch the regressions easier. > Agreed with your suggestion and I'll pick this up into Samsung tree soon. Thanks, Kukjin
Hello Kukjin, >> >> Hello Kukjin, >> > Hi Javier, > > Happy new year :) > Thanks, happy new year for you as well! >> You dropped this patch since exynos drm was causing boot hangs on some >> platforms but the fix for that issue is already in linux-next (commit: >> f1e9203 clk: samsung: Fix Exynos 5420 pinctrl setup and clock disable >> failure due to domain being gated) so I think it makes sense to enable >> the display options again. >> >> NOTE: Display panel is still not working since patch "arm: dts: Exynos5: >> Use pmu_system_controller phandle for dp phy" is needed [0] but I think >> we should enable display options to catch the regressions easier. >> > Agreed with your suggestion and I'll pick this up into Samsung tree soon. > Perfect, I hope you can pick my peach pit/pi and snow DTS updates series as well since those patches have been in the list for some time. > Thanks, > Kukjin > Best regards, Javier
diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 22beed3..27cdd52 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -111,11 +111,26 @@ CONFIG_REGULATOR_S2MPA01=y CONFIG_REGULATOR_S2MPS11=y CONFIG_REGULATOR_S5M8767=y CONFIG_REGULATOR_TPS65090=y +CONFIG_DRM=y +CONFIG_DRM_BRIDGE=y +CONFIG_DRM_PTN3460=y +CONFIG_DRM_PS8622=y +CONFIG_DRM_EXYNOS=y +CONFIG_DRM_EXYNOS_FIMD=y +CONFIG_DRM_EXYNOS_DP=y +CONFIG_DRM_PANEL=y +CONFIG_DRM_PANEL_SIMPLE=y CONFIG_FB=y CONFIG_FB_MODE_HELPERS=y CONFIG_FB_SIMPLE=y CONFIG_EXYNOS_VIDEO=y CONFIG_EXYNOS_MIPI_DSI=y +CONFIG_BACKLIGHT_LCD_SUPPORT=y +CONFIG_LCD_CLASS_DEVICE=y +CONFIG_LCD_PLATFORM=y +CONFIG_BACKLIGHT_CLASS_DEVICE=y +CONFIG_BACKLIGHT_GENERIC=y +CONFIG_BACKLIGHT_PWM=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FONTS=y CONFIG_FONT_7x14=y