diff mbox

[2/8] ASoC: cs35l32: Constify struct regmap_config and snd_soc_codec_driver

Message ID 1420449508-10701-2-git-send-email-k.kozlowski@samsung.com (mailing list archive)
State Accepted
Commit d883641f87a42cffcdbbdc664fce1def20ed02b6
Headers show

Commit Message

Krzysztof Kozlowski Jan. 5, 2015, 9:18 a.m. UTC
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const. Make struct
snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
pointer to const).

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Brian Austin <brian.austin@cirrus.com>
Cc: Paul Handrigan <Paul.Handrigan@cirrus.com>
---
 sound/soc/codecs/cs35l32.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Austin, Brian Jan. 5, 2015, 3:05 p.m. UTC | #1
> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const. Make struct
> snd_soc_codec_driver const as well (snd_soc_register_codec() accepts
> pointer to const).
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: Brian Austin <brian.austin@cirrus.com>
> Cc: Paul Handrigan <Paul.Handrigan@cirrus.com>
For the Cirrus Codecs

Acked-by: Brian Austin <brian.austin@cirrus.com>

Thanks
diff mbox

Patch

diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c
index ec55c590afd0..f2b8aad21274 100644
--- a/sound/soc/codecs/cs35l32.c
+++ b/sound/soc/codecs/cs35l32.c
@@ -264,7 +264,7 @@  static int cs35l32_codec_set_sysclk(struct snd_soc_codec *codec,
 			CS35L32_MCLK_DIV2_MASK | CS35L32_MCLK_RATIO_MASK, val);
 }
 
-static struct snd_soc_codec_driver soc_codec_dev_cs35l32 = {
+static const struct snd_soc_codec_driver soc_codec_dev_cs35l32 = {
 	.set_sysclk = cs35l32_codec_set_sysclk,
 
 	.dapm_widgets = cs35l32_dapm_widgets,
@@ -288,7 +288,7 @@  static const struct reg_default cs35l32_monitor_patch[] = {
 	{ 0x00, 0x00 },
 };
 
-static struct regmap_config cs35l32_regmap = {
+static const struct regmap_config cs35l32_regmap = {
 	.reg_bits = 8,
 	.val_bits = 8,