| Message ID | 1420275884-10942-1-git-send-email-21cnbao@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 29104c748d52d579b291ca029f4714bca7765241 |
| Headers | show |
On Sat, Jan 03, 2015 at 05:04:44PM +0800, Barry Song wrote: > From: Barry Song <Baohua.Song@csr.com> > > "sirf,marco-spi" is redundant as all SPI controllers in CSR SiRFSoC are > compatible with prima2-spi. > at the same time, the whole marco project was dropped and its replacement > atlas7 is also compatible with prima2 in SPI. I don't see any pressing reason to do this (the cost is basically zero) and the compatible string seems to be used in a DTSI file, though perhaps that's going away? I'd also say that the binding document update is missing but it seems this binding is undocumented. :/
2015-01-06 5:27 GMT+08:00 Mark Brown <broonie@kernel.org>: > On Sat, Jan 03, 2015 at 05:04:44PM +0800, Barry Song wrote: >> From: Barry Song <Baohua.Song@csr.com> >> >> "sirf,marco-spi" is redundant as all SPI controllers in CSR SiRFSoC are >> compatible with prima2-spi. >> at the same time, the whole marco project was dropped and its replacement >> atlas7 is also compatible with prima2 in SPI. > > I don't see any pressing reason to do this (the cost is basically zero) > and the compatible string seems to be used in a DTSI file, though > perhaps that's going away? its value is zero but it is necessary. this should be clear as marco has been dropped in dtsi and machine level. and there is no any reference for this string even in current codes. i think i have been wrong from this commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/spi/spi-sirf.c?id=f3b8a8ecc5922d9dff303ae2fadc1eae608a6f7c > > I'd also say that the binding document update is missing but it seems > this binding is undocumented. :/ yes. i realized i missed to include the DT doc when i sent the spi patch at the first time even though it always exists in my local tree. i will add the missed one. -barry -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jan 03, 2015 at 05:04:44PM +0800, Barry Song wrote: > From: Barry Song <Baohua.Song@csr.com> > > "sirf,marco-spi" is redundant as all SPI controllers in CSR SiRFSoC are > compatible with prima2-spi. > at the same time, the whole marco project was dropped and its replacement > atlas7 is also compatible with prima2 in SPI. Applied, thanks.
diff --git a/drivers/spi/spi-sirf.c b/drivers/spi/spi-sirf.c index d075191..f5715c9 100644 --- a/drivers/spi/spi-sirf.c +++ b/drivers/spi/spi-sirf.c @@ -818,7 +818,6 @@ static SIMPLE_DEV_PM_OPS(spi_sirfsoc_pm_ops, spi_sirfsoc_suspend, static const struct of_device_id spi_sirfsoc_of_match[] = { { .compatible = "sirf,prima2-spi", }, - { .compatible = "sirf,marco-spi", }, {} }; MODULE_DEVICE_TABLE(of, spi_sirfsoc_of_match);