diff mbox

[2/4] Documentation: dt-bindings: Add the binding info for APM X-Gene PCIe DMA driver

Message ID 1420608537-12296-3-git-send-email-mchitale@apm.com (mailing list archive)
State Rejected
Headers show

Commit Message

Mayuresh Chitale Jan. 7, 2015, 5:28 a.m. UTC 
This patch adds the device tree binding information for X-Gene PCIe DMA driver.

Signed-off-by: Mayuresh Chitale <mchitale@apm.com>
Signed-off-by: Tanmay Inamdar <tinamdar@apm.com>
---
 Documentation/devicetree/bindings/dma/xgene-pciedma.txt | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/dma/xgene-pciedma.txt

Comments

Arnd Bergmann Jan. 7, 2015, 8:30 a.m. UTC | #1 
On Wednesday 07 January 2015 10:58:55 Mayuresh Chitale wrote:
> +Required properties:
> +- compatible :
> +       - "apm,xgene-pciedma" for pcie DMA on X-Gene SoC
> +- interrupts : An interrupt-specifier which is used to handle DMA interrupts
> +
> +Examples:
> +               pciedma0 {
> +                       status = "disabled";
> +                       compatible = "apm,xgene-pciedma";
> +                       reg = < 0x0 0x1F2B0154 0x0 0xC
> +                               0x0 0x1F2B0058 0x0 0x8>;
> +                       reg-names = "cfg", "intr";
> +                       interrupts = <0x0 0xC6 0x4>;
> +               };
> 

The example contains a "reg-names" property that is neither listed
as optional nor mandatory, and that is not used by the driver.
Bettter drop that from the example.

The 'reg' property is not documented in the binding. Please
document which register each index refers to.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mayuresh Chitale Jan. 7, 2015, 10:42 a.m. UTC | #2 
Hi Arnd,

Thanks for you comments. Please see inline.

--Mayuresh.

On Wed, Jan 7, 2015 at 2:00 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 07 January 2015 10:58:55 Mayuresh Chitale wrote:
>> +Required properties:
>> +- compatible :
>> +       - "apm,xgene-pciedma" for pcie DMA on X-Gene SoC
>> +- interrupts : An interrupt-specifier which is used to handle DMA interrupts
>> +
>> +Examples:
>> +               pciedma0 {
>> +                       status = "disabled";
>> +                       compatible = "apm,xgene-pciedma";
>> +                       reg = < 0x0 0x1F2B0154 0x0 0xC
>> +                               0x0 0x1F2B0058 0x0 0x8>;
>> +                       reg-names = "cfg", "intr";
>> +                       interrupts = <0x0 0xC6 0x4>;
>> +               };
>>
>
> The example contains a "reg-names" property that is neither listed
> as optional nor mandatory, and that is not used by the driver.
> Bettter drop that from the example.
>
> The 'reg' property is not documented in the binding. Please
> document which register each index refers to.

Ok. I will make those changes.

>
>         Arnd
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/dma/xgene-pciedma.txt b/Documentation/devicetree/bindings/dma/xgene-pciedma.txt
new file mode 100644
index 0000000..52ee87a
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/xgene-pciedma.txt
@@ -0,0 +1,16 @@ 
+* X-Gene PCIe Direct Memory Access Controller
+
+Required properties:
+- compatible :
+	- "apm,xgene-pciedma" for pcie DMA on X-Gene SoC
+- interrupts : An interrupt-specifier which is used to handle DMA interrupts
+
+Examples:
+		pciedma0 {
+			status = "disabled";
+			compatible = "apm,xgene-pciedma";
+			reg = < 0x0 0x1F2B0154 0x0 0xC
+				0x0 0x1F2B0058 0x0 0x8>;
+			reg-names = "cfg", "intr";
+			interrupts = <0x0 0xC6 0x4>;
+		};