diff mbox

spi: sh-msiof: Use async pm_runtime_put() in sh_msiof_spi_setup()

Message ID 1420645045-18804-1-git-send-email-geert+renesas@glider.be (mailing list archive)
State Accepted
Commit c8935ef0f2a8e8c5c440c62fb194d40c4415f456
Headers show

Commit Message

Geert Uytterhoeven Jan. 7, 2015, 3:37 p.m. UTC
There's no need to use the synchronous version.

Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: 015760563ec77bf1 ("spi: sh-msiof: Add runtime PM lock in initializing")
---
Please note that 015760563ec77bf1 is marked for stable.

 drivers/spi/spi-sh-msiof.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mark Brown Jan. 7, 2015, 5:30 p.m. UTC | #1
On Wed, Jan 07, 2015 at 04:37:25PM +0100, Geert Uytterhoeven wrote:
> There's no need to use the synchronous version.
> 
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Fixes: 015760563ec77bf1 ("spi: sh-msiof: Add runtime PM lock in initializing")
> ---
> Please note that 015760563ec77bf1 is marked for stable.

Sure, but this is just an optimisation really.  Anyway, applied.
diff mbox

Patch

diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
index 3f7ea2d49456e754..050e9188df1b309c 100644
--- a/drivers/spi/spi-sh-msiof.c
+++ b/drivers/spi/spi-sh-msiof.c
@@ -546,7 +546,7 @@  static int sh_msiof_spi_setup(struct spi_device *spi)
 		gpio_set_value(spi->cs_gpio, !(spi->mode & SPI_CS_HIGH));
 
 
-	pm_runtime_put_sync(&p->pdev->dev);
+	pm_runtime_put(&p->pdev->dev);
 
 	return 0;
 }