| Message ID | 87lhm7t37l.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Stephen, Olof, Arnd, Rob, Andrew I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during half-year (since Jun 2014) , many times. But, no-one care it. I don't know who is the best maintainer. - Stephen : because it has Tegra ? - Olof : because it has Tegra (= ARM) ? - Arnd : because it has Tegra (= ARM) ? - Matthias: because it has Tegra (= ARM SoC) ? - Rob : because DT ? - Andrew : Last chance ? But, could you please care this patch ? I will re-send it again > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp > by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) > > It went through the appropriate review process. But, almost all > Asahi Kasei chip drivers are using "asahi-kasei" prefix today. > (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", > but there are instances of "asahi-kasei,ak8975" in other dts files. > And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) > So, we made a mistake there. > > In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" > prerfix in DT file. > (DT compatible string vendor "asahi-kasei" appears un-documented) > > Marking it deprecated and warning with checkpatch is certainly > preferable. So, this patch replace "ak" to "asahi-kasei" in > vendor-prefixes.txt. (and fixup tegra20-seaboard) > > OTOH, Asahi Kasei is usually referred to as "AKM", but this patch > doesn't care about it. Because no DT is using that today. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Acked-by: Thierry Reding <treding@nvidia.com> > Acked-by: Alexandre Courbot <acourbot@nvidia.com> > --- > >> Linus > > I had sent this patch to Linux ML and Maintainers many times, > but, no-one cares about it. > Can you please check and apply it ? > > > .../devicetree/bindings/vendor-prefixes.txt | 2 +- > arch/arm/boot/dts/tegra20-seaboard.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index 723999d..ddcb4cd 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -9,7 +9,6 @@ ad Avionic Design GmbH > adapteva Adapteva, Inc. > adi Analog Devices, Inc. > aeroflexgaisler Aeroflex Gaisler AB > -ak Asahi Kasei Corp. > allwinner Allwinner Technology Co., Ltd. > altr Altera Corp. > amcc Applied Micro Circuits Corporation (APM, formally AMCC) > @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. > apm Applied Micro Circuits Corporation (APM) > arm ARM Ltd. > armadeus ARMadeus Systems SARL > +asahi-kasei Asahi Kasei Corp. > atmel Atmel Corporation > auo AU Optronics Corporation > avago Avago Technologies > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts > index a1d4bf9..7f5cf80 100644 > --- a/arch/arm/boot/dts/tegra20-seaboard.dts > +++ b/arch/arm/boot/dts/tegra20-seaboard.dts > @@ -405,7 +405,7 @@ > clock-frequency = <400000>; > > magnetometer@c { > - compatible = "ak,ak8975"; > + compatible = "asahi-kasei,ak8975"; > reg = <0xc>; > interrupt-parent = <&gpio>; > interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>; > -- > 1.7.9.5 >
On 01/08/2015 08:40 PM, Kuninori Morimoto wrote: > > Hi Stephen, Olof, Arnd, Rob, Andrew > > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during > half-year (since Jun 2014) , many times. But, no-one care it. > I don't know who is the best maintainer. > - Stephen : because it has Tegra ? > - Olof : because it has Tegra (= ARM) ? > - Arnd : because it has Tegra (= ARM) ? > - Matthias: because it has Tegra (= ARM SoC) ? > - Rob : because DT ? > - Andrew : Last chance ? > > But, could you please care this patch ? > I will re-send it again It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively changing a DT vendor name would need that, I think. Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it seems they expect it to go through some tree other than Tegra. Weren't there a bunch of related patches along with this (e.g. updating relevant drivers to support both prefixes?) so it was expected this patch would be applied together with them? >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> >> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp >> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) >> >> It went through the appropriate review process. But, almost all >> Asahi Kasei chip drivers are using "asahi-kasei" prefix today. >> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", >> but there are instances of "asahi-kasei,ak8975" in other dts files. >> And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) >> So, we made a mistake there. >> >> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" >> prerfix in DT file. >> (DT compatible string vendor "asahi-kasei" appears un-documented) >> >> Marking it deprecated and warning with checkpatch is certainly >> preferable. So, this patch replace "ak" to "asahi-kasei" in >> vendor-prefixes.txt. (and fixup tegra20-seaboard) >> >> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch >> doesn't care about it. Because no DT is using that today. >> >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> >> Acked-by: Thierry Reding <treding@nvidia.com> >> Acked-by: Alexandre Courbot <acourbot@nvidia.com> >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt >> -ak Asahi Kasei Corp. >> +asahi-kasei Asahi Kasei Corp. >> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts >> magnetometer@c { >> - compatible = "ak,ak8975"; >> + compatible = "asahi-kasei,ak8975";
Hi Stephen Thank you for your feedback > > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during > > half-year (since Jun 2014) , many times. But, no-one care it. > > I don't know who is the best maintainer. > > - Stephen : because it has Tegra ? > > - Olof : because it has Tegra (= ARM) ? > > - Arnd : because it has Tegra (= ARM) ? > > - Matthias: because it has Tegra (= ARM SoC) ? > > - Rob : because DT ? > > - Andrew : Last chance ? > > > > But, could you please care this patch ? > > I will re-send it again > > It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively > changing a DT vendor name would need that, I think. Rob ? I had sent this patch to him since half-years ago, many times... Or other maintainer ? > Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it > seems they expect it to go through some tree other than Tegra. Weren't > there a bunch of related patches along with this (e.g. updating relevant > drivers to support both prefixes?) so it was expected this patch would > be applied together with them? I guess they expected it goes to DT branch (?) This is only 1 patch. it doesn't have related patch-set > >> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >> > >> Current vendor-prefixes.txt already has "ak" prefix for Asahi Kasei Corp > >> by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) > >> > >> It went through the appropriate review process. But, almost all > >> Asahi Kasei chip drivers are using "asahi-kasei" prefix today. > >> (arch/arm/boot/dts/tegra20-seaboard.dts only is using "ak,ak8975", > >> but there are instances of "asahi-kasei,ak8975" in other dts files. > >> And drivers/iio/magnetometer/ak8975.c doesn't support "ak,ak8975" prefix) > >> So, we made a mistake there. > >> > >> In addition, checkpatch.pl reports WARNING if it is using "asahi-kasei" > >> prerfix in DT file. > >> (DT compatible string vendor "asahi-kasei" appears un-documented) > >> > >> Marking it deprecated and warning with checkpatch is certainly > >> preferable. So, this patch replace "ak" to "asahi-kasei" in > >> vendor-prefixes.txt. (and fixup tegra20-seaboard) > >> > >> OTOH, Asahi Kasei is usually referred to as "AKM", but this patch > >> doesn't care about it. Because no DT is using that today. > >> > >> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > >> Acked-by: Thierry Reding <treding@nvidia.com> > >> Acked-by: Alexandre Courbot <acourbot@nvidia.com> > > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > > >> -ak Asahi Kasei Corp. > > >> +asahi-kasei Asahi Kasei Corp. > > >> diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts > > >> magnetometer@c { > >> - compatible = "ak,ak8975"; > >> + compatible = "asahi-kasei,ak8975"; > Best regards --- Kuninori Morimoto
On Fri, Jan 9, 2015 at 4:07 AM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > Hi Stephen > > Thank you for your feedback > >> > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during >> > half-year (since Jun 2014) , many times. But, no-one care it. >> > I don't know who is the best maintainer. >> > - Stephen : because it has Tegra ? >> > - Olof : because it has Tegra (= ARM) ? >> > - Arnd : because it has Tegra (= ARM) ? >> > - Matthias: because it has Tegra (= ARM SoC) ? >> > - Rob : because DT ? >> > - Andrew : Last chance ? >> > >> > But, could you please care this patch ? >> > I will re-send it again >> >> It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively >> changing a DT vendor name would need that, I think. > > Rob ? > I had sent this patch to him since half-years ago, many times... > Or other maintainer ? > >> Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it >> seems they expect it to go through some tree other than Tegra. Weren't >> there a bunch of related patches along with this (e.g. updating relevant >> drivers to support both prefixes?) so it was expected this patch would >> be applied together with them? > > I guess they expected it goes to DT branch (?) > This is only 1 patch. it doesn't have related patch-set It is in my queue. If the users of it are fine with breaking things, who am I to argue with them. Rob
On Friday 09 January 2015 07:46:16 Rob Herring wrote: > On Fri, Jan 9, 2015 at 4:07 AM, Kuninori Morimoto > <kuninori.morimoto.gx@renesas.com> wrote: > > > > Hi Stephen > > > > Thank you for your feedback > > > >> > I'm sending this "of: replace Asahi Kasei Corp vendor prefix" during > >> > half-year (since Jun 2014) , many times. But, no-one care it. > >> > I don't know who is the best maintainer. > >> > - Stephen : because it has Tegra ? > >> > - Olof : because it has Tegra (= ARM) ? > >> > - Arnd : because it has Tegra (= ARM) ? > >> > - Matthias: because it has Tegra (= ARM SoC) ? > >> > - Rob : because DT ? > >> > - Andrew : Last chance ? > >> > > >> > But, could you please care this patch ? > >> > I will re-send it again > >> > >> It doesn't seem to be ack'd by any of the DT maintainers. Retro-actively > >> changing a DT vendor name would need that, I think. > > > > Rob ? > > I had sent this patch to him since half-years ago, many times... > > Or other maintainer ? > > > >> Thierry and Alex (both Tegra maintainers) appear to have ack'd it, so it > >> seems they expect it to go through some tree other than Tegra. Weren't > >> there a bunch of related patches along with this (e.g. updating relevant > >> drivers to support both prefixes?) so it was expected this patch would > >> be applied together with them? > > > > I guess they expected it goes to DT branch (?) > > This is only 1 patch. it doesn't have related patch-set > > It is in my queue. If the users of it are fine with breaking things, > who am I to argue with them. It's an i2c device, so it won't break, based on the implementation we use in the kernel that ignores the vendor part when the part number matches the i2c driver name. I also don't think we need to worry about any non-Linux operating systems on this board that might share the same dts file. Arnd
On Fri, Jan 09, 2015 at 02:55:40PM +0100, Arnd Bergmann wrote: > It's an i2c device, so it won't break, based on the implementation > we use in the kernel that ignores the vendor part when the part number > matches the i2c driver name. Plus this update is actually changing the board DT file have the ID which we've always had in the driver, the driver has always used the new string and never the ak, based one that the device tree is registering.
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index 723999d..ddcb4cd 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt @@ -9,7 +9,6 @@ ad Avionic Design GmbH adapteva Adapteva, Inc. adi Analog Devices, Inc. aeroflexgaisler Aeroflex Gaisler AB -ak Asahi Kasei Corp. allwinner Allwinner Technology Co., Ltd. altr Altera Corp. amcc Applied Micro Circuits Corporation (APM, formally AMCC) @@ -20,6 +19,7 @@ amstaos AMS-Taos Inc. apm Applied Micro Circuits Corporation (APM) arm ARM Ltd. armadeus ARMadeus Systems SARL +asahi-kasei Asahi Kasei Corp. atmel Atmel Corporation auo AU Optronics Corporation avago Avago Technologies diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts b/arch/arm/boot/dts/tegra20-seaboard.dts index a1d4bf9..7f5cf80 100644 --- a/arch/arm/boot/dts/tegra20-seaboard.dts +++ b/arch/arm/boot/dts/tegra20-seaboard.dts @@ -405,7 +405,7 @@ clock-frequency = <400000>; magnetometer@c { - compatible = "ak,ak8975"; + compatible = "asahi-kasei,ak8975"; reg = <0xc>; interrupt-parent = <&gpio>; interrupts = <TEGRA_GPIO(N, 5) IRQ_TYPE_LEVEL_HIGH>;