| Message ID | 54b748fa5cb6883d6ce348c38328161409c1f1be.1418918402.git.shuahkh@osg.samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
My first code review of the new year, so let's start with a simple one to avoid taxing my brain cells (that are still in vacation mode) too much... On 12/18/2014 05:20 PM, Shuah Khan wrote: > There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap() > vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it. > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> Happy New Year! Hans > --- > drivers/media/usb/au0828/au0828-video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c > index 3011ca8..ef49b2e 100644 > --- a/drivers/media/usb/au0828/au0828-video.c > +++ b/drivers/media/usb/au0828/au0828-video.c > @@ -1104,7 +1104,6 @@ static int au0828_set_format(struct au0828_dev *dev, unsigned int cmd, > format->fmt.pix.sizeimage = width * height * 2; > format->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; > format->fmt.pix.field = V4L2_FIELD_INTERLACED; > - format->fmt.pix.priv = 0; > > if (cmd == VIDIOC_TRY_FMT) > return 0; > @@ -1189,7 +1188,6 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void *priv, > f->fmt.pix.sizeimage = dev->frame_size; > f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; /* NTSC/PAL */ > f->fmt.pix.field = V4L2_FIELD_INTERLACED; > - f->fmt.pix.priv = 0; > return 0; > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/12/2015 06:58 AM, Hans Verkuil wrote: > My first code review of the new year, so let's start with a simple one to avoid > taxing my brain cells (that are still in vacation mode) too much... > > On 12/18/2014 05:20 PM, Shuah Khan wrote: >> There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap() >> vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it. >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > Thanks. -- Shuah
On 01/12/2015 06:58 AM, Hans Verkuil wrote: > My first code review of the new year, so let's start with a simple one to avoid > taxing my brain cells (that are still in vacation mode) too much... > > On 12/18/2014 05:20 PM, Shuah Khan wrote: >> There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap() >> vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it. >> >> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> > > Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > Happy New Year! Hans, Thanks. Just FYI, I dropped this patch from the patch v3 series since it has been Acked. Please note that that this version is what needs to be pulled in. thanks, -- Shuah
Hi Shuah, Thanks for the patch. On Thu, Dec 18, 2014 at 4:20 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote: > There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap() > vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it. > > Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Regards, --Prabhakar Lad > --- > drivers/media/usb/au0828/au0828-video.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c > index 3011ca8..ef49b2e 100644 > --- a/drivers/media/usb/au0828/au0828-video.c > +++ b/drivers/media/usb/au0828/au0828-video.c > @@ -1104,7 +1104,6 @@ static int au0828_set_format(struct au0828_dev *dev, unsigned int cmd, > format->fmt.pix.sizeimage = width * height * 2; > format->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; > format->fmt.pix.field = V4L2_FIELD_INTERLACED; > - format->fmt.pix.priv = 0; > > if (cmd == VIDIOC_TRY_FMT) > return 0; > @@ -1189,7 +1188,6 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void *priv, > f->fmt.pix.sizeimage = dev->frame_size; > f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; /* NTSC/PAL */ > f->fmt.pix.field = V4L2_FIELD_INTERLACED; > - f->fmt.pix.priv = 0; > return 0; > } > > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/usb/au0828/au0828-video.c b/drivers/media/usb/au0828/au0828-video.c index 3011ca8..ef49b2e 100644 --- a/drivers/media/usb/au0828/au0828-video.c +++ b/drivers/media/usb/au0828/au0828-video.c @@ -1104,7 +1104,6 @@ static int au0828_set_format(struct au0828_dev *dev, unsigned int cmd, format->fmt.pix.sizeimage = width * height * 2; format->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; format->fmt.pix.field = V4L2_FIELD_INTERLACED; - format->fmt.pix.priv = 0; if (cmd == VIDIOC_TRY_FMT) return 0; @@ -1189,7 +1188,6 @@ static int vidioc_g_fmt_vid_cap(struct file *file, void *priv, f->fmt.pix.sizeimage = dev->frame_size; f->fmt.pix.colorspace = V4L2_COLORSPACE_SMPTE170M; /* NTSC/PAL */ f->fmt.pix.field = V4L2_FIELD_INTERLACED; - f->fmt.pix.priv = 0; return 0; }
There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap() vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it. Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> --- drivers/media/usb/au0828/au0828-video.c | 2 -- 1 file changed, 2 deletions(-)