| Message ID | 54B4D9ED.4010100@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 13, 2015 at 3:40 AM, Maarten Lankhorst <maarten.lankhorst@canonical.com> wrote: > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> Does this fix anything or is it purely cosmetic? Alex > --- > diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c > index 29b9220ec399..3d201e937571 100644 > --- a/drivers/gpu/drm/radeon/radeon_fb.c > +++ b/drivers/gpu/drm/radeon/radeon_fb.c > @@ -257,6 +257,7 @@ static int radeonfb_create(struct drm_fb_helper *helper, > } > > info->par = rfbdev; > + info->skip_vt_switch = true; > > ret = radeon_framebuffer_init(rdev->ddev, &rfbdev->rfb, &mode_cmd, gobj); > if (ret) {
Op 13-01-15 om 15:51 schreef Alex Deucher: > On Tue, Jan 13, 2015 at 3:40 AM, Maarten Lankhorst > <maarten.lankhorst@canonical.com> wrote: >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> > Does this fix anything or is it purely cosmetic? It gets rid of unnecessarily switching to the suspend console, resulting in no longer having a xorg vt switch on suspend. So probably just cosmetic. In nouveau it exposed a bug with LUT restore and cursor save/restore. :-) ~Maarten
On Tue, Jan 13, 2015 at 9:55 AM, Maarten Lankhorst <maarten.lankhorst@canonical.com> wrote: > Op 13-01-15 om 15:51 schreef Alex Deucher: >> On Tue, Jan 13, 2015 at 3:40 AM, Maarten Lankhorst >> <maarten.lankhorst@canonical.com> wrote: >>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> >> Does this fix anything or is it purely cosmetic? > It gets rid of unnecessarily switching to the suspend console, resulting in no longer having a xorg vt switch on suspend. > > So probably just cosmetic. In nouveau it exposed a bug with LUT restore and cursor save/restore. :-) Assuming it works ok, Acked-by: Alex Deucher <alexander.deucher@amd.com>
diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c index 29b9220ec399..3d201e937571 100644 --- a/drivers/gpu/drm/radeon/radeon_fb.c +++ b/drivers/gpu/drm/radeon/radeon_fb.c @@ -257,6 +257,7 @@ static int radeonfb_create(struct drm_fb_helper *helper, } info->par = rfbdev; + info->skip_vt_switch = true; ret = radeon_framebuffer_init(rdev->ddev, &rfbdev->rfb, &mode_cmd, gobj); if (ret) {
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com> ---