| Message ID | 1421392784-32298-2-git-send-email-voice.shen@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> As the clock can be get from TK/RK pin, so remove the comments. > > Signed-off-by: Bo Shen <voice.shen@atmel.com> > --- > sound/soc/atmel/atmel_ssc_dai.c | 4 ---- > 1 file changed, 4 deletions(-) > diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c > index e691aab..198661b 100644 > --- a/sound/soc/atmel/atmel_ssc_dai.c > +++ b/sound/soc/atmel/atmel_ssc_dai.c > @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, > case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM: > /* > * I2S format, CODEC supplies BCLK and LRC clocks. > - * > - * The SSC transmit clock is obtained from the BCLK signal on > - * on the TK line, and the SSC receive clock is > - * generated from the transmit clock. > */ > rcmr = SSC_BF(RCMR_PERIOD, 0) > | SSC_BF(RCMR_STTDLY, START_DELAY) > -- > 2.3.0.rc0 Hi! You should probably remove that comment from the case with SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well... Cheers, Peter
Hi Peter, On 01/19/2015 09:54 PM, Peter Rosin wrote: >> As the clock can be get from TK/RK pin, so remove the comments. >> >> Signed-off-by: Bo Shen <voice.shen@atmel.com> >> --- >> sound/soc/atmel/atmel_ssc_dai.c | 4 ---- >> 1 file changed, 4 deletions(-) >> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c >> index e691aab..198661b 100644 >> --- a/sound/soc/atmel/atmel_ssc_dai.c >> +++ b/sound/soc/atmel/atmel_ssc_dai.c >> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, >> case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM: >> /* >> * I2S format, CODEC supplies BCLK and LRC clocks. >> - * >> - * The SSC transmit clock is obtained from the BCLK signal on >> - * on the TK line, and the SSC receive clock is >> - * generated from the transmit clock. >> */ >> rcmr = SSC_BF(RCMR_PERIOD, 0) >> | SSC_BF(RCMR_STTDLY, START_DELAY) >> -- >> 2.3.0.rc0 > > Hi! > > You should probably remove that comment from the case with > SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well... Thanks, I will remove it in next version. > Cheers, > Peter > Best Regards, Bo Shen
diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index e691aab..198661b 100644 --- a/sound/soc/atmel/atmel_ssc_dai.c +++ b/sound/soc/atmel/atmel_ssc_dai.c @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM: /* * I2S format, CODEC supplies BCLK and LRC clocks. - * - * The SSC transmit clock is obtained from the BCLK signal on - * on the TK line, and the SSC receive clock is - * generated from the transmit clock. */ rcmr = SSC_BF(RCMR_PERIOD, 0) | SSC_BF(RCMR_STTDLY, START_DELAY)
As the clock can be get from TK/RK pin, so remove the comments. Signed-off-by: Bo Shen <voice.shen@atmel.com> --- sound/soc/atmel/atmel_ssc_dai.c | 4 ---- 1 file changed, 4 deletions(-)