diff mbox

[8/8,v2] ASoC: rsnd: remove slave_id settings for DMAEngine

Message ID 87a91eaxtc.wl%kuninori.morimoto.gx@renesas.com (mailing list archive)
State Superseded
Headers show

Commit Message

Kuninori Morimoto Jan. 20, 2015, 4:18 a.m. UTC 
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current sh-msiof sets dma_slave_config :: slave_id field for DMAEngine,
but it is no longer needed. Let's remove it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2

 - separate into shdma and others

 sound/soc/sh/rcar/core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Sergei Shtylyov Jan. 20, 2015, 11:23 a.m. UTC | #1 
Hello.

On 1/20/2015 7:18 AM, Kuninori Morimoto wrote:

> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

> Current sh-msiof sets dma_slave_config :: slave_id field for DMAEngine,

    sh-msiof? But this is ALSA patch! :-)

> but it is no longer needed. Let's remove it.

> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Kuninori Morimoto Jan. 21, 2015, 1:28 a.m. UTC | #2 
Hi Sergei

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> > Current sh-msiof sets dma_slave_config :: slave_id field for DMAEngine,
> 
>     sh-msiof? But this is ALSA patch! :-)
> 
> > but it is no longer needed. Let's remove it.

Grr... Thank you for pointing it.
will fix in v3 patch

Best regards
---
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
index 75308bb..61473d9 100644
--- a/sound/soc/sh/rcar/core.c
+++ b/sound/soc/sh/rcar/core.c
@@ -316,7 +316,7 @@  int rsnd_dma_init(struct rsnd_priv *priv, struct rsnd_dma *dma,
 		  int is_play, int id)
 {
 	struct device *dev = rsnd_priv_to_dev(priv);
-	struct dma_slave_config cfg;
+	struct dma_slave_config cfg = {};
 	struct rsnd_mod *mod_from;
 	struct rsnd_mod *mod_to;
 	char dma_name[DMA_NAME_SIZE];
@@ -334,7 +334,6 @@  int rsnd_dma_init(struct rsnd_priv *priv, struct rsnd_dma *dma,
 	rsnd_dma_of_path(dma, is_play, &mod_from, &mod_to);
 	rsnd_dma_of_name(mod_from, mod_to, dma_name);
 
-	cfg.slave_id	= id;
 	cfg.direction	= is_play ? DMA_MEM_TO_DEV : DMA_DEV_TO_MEM;
 	cfg.src_addr	= rsnd_gen_dma_addr(priv, mod_from, is_play, 1);
 	cfg.dst_addr	= rsnd_gen_dma_addr(priv, mod_to,   is_play, 0);