diff mbox

[2/5] rapidio/tsi721: use PCI define for max read request size

Message ID 1422291962-12374-1-git-send-email-zajec5@gmail.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Rafał Miłecki Jan. 26, 2015, 5:06 p.m. UTC
Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
---
 drivers/rapidio/devices/tsi721.c | 2 +-
 drivers/rapidio/devices/tsi721.h | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Bounine, Alexandre Jan. 26, 2015, 6:15 p.m. UTC | #1
Acked-by: Alexandre Bounine <alexandre.bounine@idt.com>


> -----Original Message-----

> From: Rafa? Mi?ecki [mailto:zajec5@gmail.com]

> Sent: Monday, January 26, 2015 12:06 PM

> To: Bjorn Helgaas; linux-pci@vger.kernel.org

> Cc: Matt Porter; Bounine, Alexandre; Rafa? Mi?ecki

> Subject: [PATCH 2/5] rapidio/tsi721: use PCI define for max read

> request size

> 

> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>

> ---

>  drivers/rapidio/devices/tsi721.c | 2 +-

> drivers/rapidio/devices/tsi721.h | 2 --

>  2 files changed, 1 insertion(+), 3 deletions(-)

> 

> diff --git a/drivers/rapidio/devices/tsi721.c

> b/drivers/rapidio/devices/tsi721.c

> index 8bcfecd..eeca70d 100644

> --- a/drivers/rapidio/devices/tsi721.c

> +++ b/drivers/rapidio/devices/tsi721.c

> @@ -2430,7 +2430,7 @@ static int tsi721_probe(struct pci_dev *pdev,

>  	pcie_capability_clear_and_set_word(pdev, PCI_EXP_DEVCTL,

>  		PCI_EXP_DEVCTL_READRQ | PCI_EXP_DEVCTL_RELAX_EN |

>  		PCI_EXP_DEVCTL_NOSNOOP_EN,

> -		0x2 << MAX_READ_REQUEST_SZ_SHIFT);

> +		PCI_EXP_DEVCTL_READRQ_512B);

> 

>  	/* Adjust PCIe completion timeout. */

>  	pcie_capability_clear_and_set_word(pdev, PCI_EXP_DEVCTL2, 0xf,

> 0x2); diff --git a/drivers/rapidio/devices/tsi721.h

> b/drivers/rapidio/devices/tsi721.h

> index a7b4268..9d25025 100644

> --- a/drivers/rapidio/devices/tsi721.h

> +++ b/drivers/rapidio/devices/tsi721.h

> @@ -72,8 +72,6 @@

>  #define TSI721_MSIXPBA_OFFSET	0x2a000

>  #define TSI721_PCIECFG_EPCTL	0x400

> 

> -#define MAX_READ_REQUEST_SZ_SHIFT	12

> -

>  /*

>   * Event Management Registers

>   */

> --

> 1.8.4.5
diff mbox

Patch

diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c
index 8bcfecd..eeca70d 100644
--- a/drivers/rapidio/devices/tsi721.c
+++ b/drivers/rapidio/devices/tsi721.c
@@ -2430,7 +2430,7 @@  static int tsi721_probe(struct pci_dev *pdev,
 	pcie_capability_clear_and_set_word(pdev, PCI_EXP_DEVCTL,
 		PCI_EXP_DEVCTL_READRQ | PCI_EXP_DEVCTL_RELAX_EN |
 		PCI_EXP_DEVCTL_NOSNOOP_EN,
-		0x2 << MAX_READ_REQUEST_SZ_SHIFT);
+		PCI_EXP_DEVCTL_READRQ_512B);
 
 	/* Adjust PCIe completion timeout. */
 	pcie_capability_clear_and_set_word(pdev, PCI_EXP_DEVCTL2, 0xf, 0x2);
diff --git a/drivers/rapidio/devices/tsi721.h b/drivers/rapidio/devices/tsi721.h
index a7b4268..9d25025 100644
--- a/drivers/rapidio/devices/tsi721.h
+++ b/drivers/rapidio/devices/tsi721.h
@@ -72,8 +72,6 @@ 
 #define TSI721_MSIXPBA_OFFSET	0x2a000
 #define TSI721_PCIECFG_EPCTL	0x400
 
-#define MAX_READ_REQUEST_SZ_SHIFT	12
-
 /*
  * Event Management Registers
  */