diff mbox

[v11,23/28] scripts/gdb: Ignore byte-compiled python files

Message ID fd0c2a6ad6e1d021ce85798f9cd89d9e3381288e.1422514006.git.jan.kiszka@siemens.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Kiszka Jan. 29, 2015, 6:46 a.m. UTC 
From: Daniel Thompson <daniel.thompson@linaro.org>

Using the gdb scripts leaves byte-compiled python files in the scripts/
directory. These should be ignored by git and cleaned up by mrproper.

Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 .gitignore                   | 1 +
 Makefile                     | 3 ++-
 scripts/gdb/linux/.gitignore | 2 ++
 3 files changed, 5 insertions(+), 1 deletion(-)
 create mode 100644 scripts/gdb/linux/.gitignore

Comments

Michal Marek Jan. 29, 2015, 1:15 p.m. UTC | #1 
On 2015-01-29 07:46, Jan Kiszka wrote:
> --- a/Makefile
> +++ b/Makefile
> @@ -1179,7 +1179,8 @@ MRPROPER_FILES += .config .config.old .version .old_version $(version_h) \
>  		  Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \
>  		  signing_key.priv signing_key.x509 x509.genkey		\
>  		  extra_certificates signing_key.x509.keyid		\
> -		  signing_key.x509.signer vmlinux-gdb.py
> +		  signing_key.x509.signer vmlinux-gdb.py		\
> +		  scripts/gdb/linux/*.py[co]

In 01/28, you already have

+clean-files := *.pyc $(if $(KBUILD_SRC),*.py)

Maybe just add *.pyo there and you don't need to add it to the toplevel
Makefile.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Kiszka Jan. 29, 2015, 1:35 p.m. UTC | #2 
On 2015-01-29 14:15, Michal Marek wrote:
> On 2015-01-29 07:46, Jan Kiszka wrote:
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1179,7 +1179,8 @@ MRPROPER_FILES += .config .config.old .version .old_version $(version_h) \
>>  		  Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \
>>  		  signing_key.priv signing_key.x509 x509.genkey		\
>>  		  extra_certificates signing_key.x509.keyid		\
>> -		  signing_key.x509.signer vmlinux-gdb.py
>> +		  signing_key.x509.signer vmlinux-gdb.py		\
>> +		  scripts/gdb/linux/*.py[co]
> 
> In 01/28, you already have
> 
> +clean-files := *.pyc $(if $(KBUILD_SRC),*.py)
> 
> Maybe just add *.pyo there and you don't need to add it to the toplevel
> Makefile.

Based on a quick test, you seem right. Daniel, anything we miss?

Thanks,
Jan
Daniel Thompson Jan. 29, 2015, 2:34 p.m. UTC | #3 
On 29/01/15 13:35, Jan Kiszka wrote:
> On 2015-01-29 14:15, Michal Marek wrote:
>> On 2015-01-29 07:46, Jan Kiszka wrote:
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1179,7 +1179,8 @@ MRPROPER_FILES += .config .config.old .version .old_version $(version_h) \
>>>  		  Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \
>>>  		  signing_key.priv signing_key.x509 x509.genkey		\
>>>  		  extra_certificates signing_key.x509.keyid		\
>>> -		  signing_key.x509.signer vmlinux-gdb.py
>>> +		  signing_key.x509.signer vmlinux-gdb.py		\
>>> +		  scripts/gdb/linux/*.py[co]
>>
>> In 01/28, you already have
>>
>> +clean-files := *.pyc $(if $(KBUILD_SRC),*.py)
>>
>> Maybe just add *.pyo there and you don't need to add it to the toplevel
>> Makefile.
> 
> Based on a quick test, you seem right. Daniel, anything we miss?

No. Deleting it with the clean rule makes sense.

Of course the .gitignore parts of my patch will still be needed in some
form or other.


Daniel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Kiszka Jan. 29, 2015, 2:41 p.m. UTC | #4 
On 2015-01-29 15:34, Daniel Thompson wrote:
> On 29/01/15 13:35, Jan Kiszka wrote:
>> On 2015-01-29 14:15, Michal Marek wrote:
>>> On 2015-01-29 07:46, Jan Kiszka wrote:
>>>> --- a/Makefile
>>>> +++ b/Makefile
>>>> @@ -1179,7 +1179,8 @@ MRPROPER_FILES += .config .config.old .version .old_version $(version_h) \
>>>>  		  Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \
>>>>  		  signing_key.priv signing_key.x509 x509.genkey		\
>>>>  		  extra_certificates signing_key.x509.keyid		\
>>>> -		  signing_key.x509.signer vmlinux-gdb.py
>>>> +		  signing_key.x509.signer vmlinux-gdb.py		\
>>>> +		  scripts/gdb/linux/*.py[co]
>>>
>>> In 01/28, you already have
>>>
>>> +clean-files := *.pyc $(if $(KBUILD_SRC),*.py)
>>>
>>> Maybe just add *.pyo there and you don't need to add it to the toplevel
>>> Makefile.
>>
>> Based on a quick test, you seem right. Daniel, anything we miss?
> 
> No. Deleting it with the clean rule makes sense.
> 
> Of course the .gitignore parts of my patch will still be needed in some
> form or other.

Sure. Can you provide an updated version, one that augments the
clean-files rule instead? Then I'll sign-off and include it in a
potential follow-up round.

Thanks,
Jan
diff mbox

Patch

diff --git a/.gitignore b/.gitignore
index ce57b79..ecb89e3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -43,6 +43,7 @@  Module.symvers
 /TAGS
 /linux
 /vmlinux
+/vmlinux-gdb.py
 /vmlinuz
 /System.map
 /Module.markers
diff --git a/Makefile b/Makefile
index 6881ddf..ee7394e 100644
--- a/Makefile
+++ b/Makefile
@@ -1179,7 +1179,8 @@  MRPROPER_FILES += .config .config.old .version .old_version $(version_h) \
 		  Module.symvers tags TAGS cscope* GPATH GTAGS GRTAGS GSYMS \
 		  signing_key.priv signing_key.x509 x509.genkey		\
 		  extra_certificates signing_key.x509.keyid		\
-		  signing_key.x509.signer vmlinux-gdb.py
+		  signing_key.x509.signer vmlinux-gdb.py		\
+		  scripts/gdb/linux/*.py[co]
 
 # clean - Delete most, but leave enough to build external modules
 #
diff --git a/scripts/gdb/linux/.gitignore b/scripts/gdb/linux/.gitignore
new file mode 100644
index 0000000..52e4e61
--- /dev/null
+++ b/scripts/gdb/linux/.gitignore
@@ -0,0 +1,2 @@ 
+*.pyc
+*.pyo