| Message ID | 1422744510-3179-5-git-send-email-robert.jarzmik@free.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 2/1/2015 1:48 AM, Robert Jarzmik wrote: > Each pxa has an embedded OS Timers IP. The kernel cannot work without a > valid clocksource, and this adds the OS Timers to the pxa device-tree > description. > Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> > --- > arch/arm/boot/dts/pxa27x.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi > index 7f93828..9e6bf60 100644 > --- a/arch/arm/boot/dts/pxa27x.dtsi > +++ b/arch/arm/boot/dts/pxa27x.dtsi > @@ -97,5 +97,18 @@ > status = "okay"; > }; > }; > + > + clocksources { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + pxa-timer@40a00000 { Just "timer@40a00000", please. WBR, Sergei
On Sat, Jan 31, 2015 at 10:48:30PM +0000, Robert Jarzmik wrote: > Each pxa has an embedded OS Timers IP. The kernel cannot work without a > valid clocksource, and this adds the OS Timers to the pxa device-tree > description. > > Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> > --- > arch/arm/boot/dts/pxa27x.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi > index 7f93828..9e6bf60 100644 > --- a/arch/arm/boot/dts/pxa27x.dtsi > +++ b/arch/arm/boot/dts/pxa27x.dtsi > @@ -97,5 +97,18 @@ > status = "okay"; > }; > }; > + > + clocksources { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + There is absolutely no need for this container node. Please get rid of it and place the node below directly under the parent node. Mark. > + pxa-timer@40a00000 { > + compatible = "marvell,pxa-timer"; > + reg = <0x40a00000 0x20>; > + interrupts = <26>; > + clocks = <&pxa2xx_clks CLK_OSTIMER>; > + status = "okay"; > + }; > }; > }; > -- > 2.1.0 > >
Mark Rutland <mark.rutland@arm.com> writes: > On Sat, Jan 31, 2015 at 10:48:30PM +0000, Robert Jarzmik wrote: >> + clocksources { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + > > There is absolutely no need for this container node. > > Please get rid of it and place the node below directly under the parent > node. OK. Cheers. -- Robert
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes: >> + clocksources { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + >> + pxa-timer@40a00000 { > > Just "timer@40a00000", please. Hi Sergei, I forgot that in the v2, sorry. I'll put it in v3. Cheers.
diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi index 7f93828..9e6bf60 100644 --- a/arch/arm/boot/dts/pxa27x.dtsi +++ b/arch/arm/boot/dts/pxa27x.dtsi @@ -97,5 +97,18 @@ status = "okay"; }; }; + + clocksources { + #address-cells = <1>; + #size-cells = <1>; + ranges; + + pxa-timer@40a00000 { + compatible = "marvell,pxa-timer"; + reg = <0x40a00000 0x20>; + interrupts = <26>; + clocks = <&pxa2xx_clks CLK_OSTIMER>; + status = "okay"; + }; }; };
Each pxa has an embedded OS Timers IP. The kernel cannot work without a valid clocksource, and this adds the OS Timers to the pxa device-tree description. Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr> --- arch/arm/boot/dts/pxa27x.dtsi | 13 +++++++++++++ 1 file changed, 13 insertions(+)