| Message ID | 1416231775-31252-60-git-send-email-maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Nov 17, 2014 at 9:42 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > For the slave caps retrieval to be really useful, most drivers need to > implement it. > > Hence, we need to be slightly more aggressive, and trigger a warning at > registration time for drivers that don't fill their caps infos in order to > encourage them to implement it. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/dma/dmaengine.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c > index 98e9431f85ec..300c8cd2786c 100644 > --- a/drivers/dma/dmaengine.c > +++ b/drivers/dma/dmaengine.c > @@ -827,6 +827,9 @@ int dma_async_device_register(struct dma_device *device) > BUG_ON(!device->device_issue_pending); > BUG_ON(!device->dev); > > + WARN(dma_has_cap(DMA_SLAVE, device->cap_mask) && !device->directions, > + "this driver doesn't support generic slave capabilities reporting\n"); > + > /* note: this only matters in the > * CONFIG_ASYNC_TX_ENABLE_CHANNEL_SWITCH=n case > */ Probably you need to fix this ? https://bugzilla.kernel.org/show_bug.cgi?id=90801 -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Viresh, On Thu, 19 Feb 2015 15:57:27 +0800, Viresh Kumar wrote: > On Mon, Nov 17, 2014 at 9:42 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > For the slave caps retrieval to be really useful, most drivers need to > > implement it. > > > > Hence, we need to be slightly more aggressive, and trigger a warning at > > registration time for drivers that don't fill their caps infos in order to > > encourage them to implement it. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > drivers/dma/dmaengine.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c > > index 98e9431f85ec..300c8cd2786c 100644 > > --- a/drivers/dma/dmaengine.c > > +++ b/drivers/dma/dmaengine.c > > @@ -827,6 +827,9 @@ int dma_async_device_register(struct dma_device *device) > > BUG_ON(!device->device_issue_pending); > > BUG_ON(!device->dev); > > > > + WARN(dma_has_cap(DMA_SLAVE, device->cap_mask) && !device->directions, > > + "this driver doesn't support generic slave capabilities reporting\n"); > > + > > /* note: this only matters in the > > * CONFIG_ASYNC_TX_ENABLE_CHANNEL_SWITCH=n case > > */ > > Probably you need to fix this ? > > https://bugzilla.kernel.org/show_bug.cgi?id=90801 My understanding is that the warning message is here on purpose to instruct DMA driver authors to fix their code. So if anyone need to fix anything, that would be you and Andy. That being said, I suspect Andy already did that: commit 029a40e97d0db269f4a7fc02b0f29f627f628309 Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Date: Fri Jan 2 16:17:24 2015 +0200 dmaengine: dw: provide DMA capabilities Brian, can you please try the latest Linus or linux-next kernel (or backport the above commit to your current kernel) and confirm that the backtraces are no longer printed? Thanks,
On 19 February 2015 at 13:39, Jean Delvare <jdelvare@suse.de> wrote: > My understanding is that the warning message is here on purpose to > instruct DMA driver authors to fix their code. So if anyone need to fix > anything, that would be you and Andy. That being said, I suspect Andy To some extent yes, but Andy has already tried to fix that for most of the drivers and so I just pointed out that something is missed. > already did that: > > commit 029a40e97d0db269f4a7fc02b0f29f627f628309 > Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Date: Fri Jan 2 16:17:24 2015 +0200 > > dmaengine: dw: provide DMA capabilities > > Brian, can you please try the latest Linus or linux-next kernel (or > backport the above commit to your current kernel) and confirm that the > backtraces are no longer printed? Maybe yes. -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 19, 2015 at 02:23:27PM +0530, Viresh Kumar wrote: > On 19 February 2015 at 13:39, Jean Delvare <jdelvare@suse.de> wrote: > > My understanding is that the warning message is here on purpose to > > instruct DMA driver authors to fix their code. So if anyone need to fix > > anything, that would be you and Andy. That being said, I suspect Andy > > To some extent yes, but Andy has already tried to fix that for most of > the drivers and so I just pointed out that something is missed. > > > already did that: > > > > commit 029a40e97d0db269f4a7fc02b0f29f627f628309 > > Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Date: Fri Jan 2 16:17:24 2015 +0200 > > > > dmaengine: dw: provide DMA capabilities > > > > Brian, can you please try the latest Linus or linux-next kernel (or > > backport the above commit to your current kernel) and confirm that the > > backtraces are no longer printed? > > Maybe yes. This warning was intentionally added to help move driver use the right method. And I have applied patch from Andy for this, so this should be no longer seen on Linus's tree
diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index 98e9431f85ec..300c8cd2786c 100644 --- a/drivers/dma/dmaengine.c +++ b/drivers/dma/dmaengine.c @@ -827,6 +827,9 @@ int dma_async_device_register(struct dma_device *device) BUG_ON(!device->device_issue_pending); BUG_ON(!device->dev); + WARN(dma_has_cap(DMA_SLAVE, device->cap_mask) && !device->directions, + "this driver doesn't support generic slave capabilities reporting\n"); + /* note: this only matters in the * CONFIG_ASYNC_TX_ENABLE_CHANNEL_SWITCH=n case */