diff mbox

[1/2] ASoC: wm_adsp: Ensure DSP controls are always persistent

Message ID 1424100349-10520-1-git-send-email-ckeepax@opensource.wolfsonmicro.com (mailing list archive)
State Accepted
Commit 65d17a9ce9f24a3aaf7d614251fdcc1b2121765f
Headers show

Commit Message

Charles Keepax Feb. 16, 2015, 3:25 p.m. UTC 
From: Nikesh Oswal <Nikesh.Oswal@wolfsonmicro.com>

Currently DSP controls are persistent (across DSP On/Off) only
if they were set whilst the DSP is off. This change makes the
controls persistent irrespective of when they are set.

Signed-off-by: Nikesh Oswal <Nikesh.Oswal@wolfsonmicro.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/wm_adsp.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

Comments

Mark Brown Feb. 21, 2015, 9:35 a.m. UTC | #1 
On Mon, Feb 16, 2015 at 03:25:48PM +0000, Charles Keepax wrote:
> From: Nikesh Oswal <Nikesh.Oswal@wolfsonmicro.com>
> 
> Currently DSP controls are persistent (across DSP On/Off) only
> if they were set whilst the DSP is off. This change makes the
> controls persistent irrespective of when they are set.

Applied both, thanks.
diff mbox

Patch

diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c
index ff67b33..185ee85 100644
--- a/sound/soc/codecs/wm_adsp.c
+++ b/sound/soc/codecs/wm_adsp.c
@@ -420,10 +420,9 @@  static int wm_coeff_put(struct snd_kcontrol *kcontrol,
 
 	memcpy(ctl->cache, p, ctl->len);
 
-	if (!ctl->enabled) {
-		ctl->set = 1;
+	ctl->set = 1;
+	if (!ctl->enabled)
 		return 0;
-	}
 
 	return wm_coeff_write_control(kcontrol, p, ctl->len);
 }