| Message ID | 1424790150-8450-1-git-send-email-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 24 February 2015 at 08:02, Sudeep Holla <sudeep.holla@arm.com> wrote: > Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ > to drivers/usb/isp1760/") moved the isp1760 driver and changed the > Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable > directly anymore. This results in driver being not compiled in when > using vexpress_defconfig and the USB is non-functional. > > This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to > get back USB functional on vexpress platforms. > > Cc: Liviu Dudau <liviu.dudau@arm.com> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > arch/arm/configs/vexpress_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/configs/vexpress_defconfig b/arch/arm/configs/vexpress_defconfig > index f489fdaa19b8..37fe607a4ede 100644 > --- a/arch/arm/configs/vexpress_defconfig > +++ b/arch/arm/configs/vexpress_defconfig > @@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y > CONFIG_USB=y > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > CONFIG_USB_MON=y > -CONFIG_USB_ISP1760_HCD=y > CONFIG_USB_STORAGE=y > +CONFIG_USB_ISP1760=y > CONFIG_MMC=y > CONFIG_MMC_ARMMMCI=y > CONFIG_NEW_LEDS=y > -- > 1.9.1 I tested this change and confirm that it does indeed re-activate USB functionality. Mathieu > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On 24/02/15 15:08, Mathieu Poirier wrote: > On 24 February 2015 at 08:02, Sudeep Holla <sudeep.holla@arm.com> wrote: >> Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ >> to drivers/usb/isp1760/") moved the isp1760 driver and changed the >> Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable >> directly anymore. This results in driver being not compiled in when >> using vexpress_defconfig and the USB is non-functional. >> >> This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to >> get back USB functional on vexpress platforms. >> >> Cc: Liviu Dudau <liviu.dudau@arm.com> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> --- >> arch/arm/configs/vexpress_defconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/configs/vexpress_defconfig b/arch/arm/configs/vexpress_defconfig >> index f489fdaa19b8..37fe607a4ede 100644 >> --- a/arch/arm/configs/vexpress_defconfig >> +++ b/arch/arm/configs/vexpress_defconfig >> @@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y >> CONFIG_USB=y >> CONFIG_USB_ANNOUNCE_NEW_DEVICES=y >> CONFIG_USB_MON=y >> -CONFIG_USB_ISP1760_HCD=y >> CONFIG_USB_STORAGE=y >> +CONFIG_USB_ISP1760=y >> CONFIG_MMC=y >> CONFIG_MMC_ARMMMCI=y >> CONFIG_NEW_LEDS=y >> -- >> 1.9.1 > > I tested this change and confirm that it does indeed re-activate USB > functionality. Thanks indeed. So I assume we can add Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org> Regards, Sudeep
On 24 February 2015 at 08:17, Sudeep Holla <sudeep.holla@arm.com> wrote: > > > On 24/02/15 15:08, Mathieu Poirier wrote: >> >> On 24 February 2015 at 08:02, Sudeep Holla <sudeep.holla@arm.com> wrote: >>> >>> Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ >>> to drivers/usb/isp1760/") moved the isp1760 driver and changed the >>> Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable >>> directly anymore. This results in driver being not compiled in when >>> using vexpress_defconfig and the USB is non-functional. >>> >>> This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to >>> get back USB functional on vexpress platforms. >>> >>> Cc: Liviu Dudau <liviu.dudau@arm.com> >>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >>> --- >>> arch/arm/configs/vexpress_defconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/configs/vexpress_defconfig >>> b/arch/arm/configs/vexpress_defconfig >>> index f489fdaa19b8..37fe607a4ede 100644 >>> --- a/arch/arm/configs/vexpress_defconfig >>> +++ b/arch/arm/configs/vexpress_defconfig >>> @@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y >>> CONFIG_USB=y >>> CONFIG_USB_ANNOUNCE_NEW_DEVICES=y >>> CONFIG_USB_MON=y >>> -CONFIG_USB_ISP1760_HCD=y >>> CONFIG_USB_STORAGE=y >>> +CONFIG_USB_ISP1760=y >>> CONFIG_MMC=y >>> CONFIG_MMC_ARMMMCI=y >>> CONFIG_NEW_LEDS=y >>> -- >>> 1.9.1 >> >> >> I tested this change and confirm that it does indeed re-activate USB >> functionality. > > > Thanks indeed. So I assume we can add > > Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org> You sure can. > > Regards, > Sudeep >
Hi Arnd, On 24/02/15 17:10, Mathieu Poirier wrote: > On 24 February 2015 at 08:17, Sudeep Holla <sudeep.holla@arm.com> wrote: >> >> >> On 24/02/15 15:08, Mathieu Poirier wrote: >>> >>> On 24 February 2015 at 08:02, Sudeep Holla <sudeep.holla@arm.com> wrote: >>>> >>>> Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ >>>> to drivers/usb/isp1760/") moved the isp1760 driver and changed the >>>> Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable >>>> directly anymore. This results in driver being not compiled in when >>>> using vexpress_defconfig and the USB is non-functional. >>>> >>>> This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to >>>> get back USB functional on vexpress platforms. >>>> >>>> Cc: Liviu Dudau <liviu.dudau@arm.com> >>>> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> >>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >>>> --- >>>> arch/arm/configs/vexpress_defconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/configs/vexpress_defconfig >>>> b/arch/arm/configs/vexpress_defconfig >>>> index f489fdaa19b8..37fe607a4ede 100644 >>>> --- a/arch/arm/configs/vexpress_defconfig >>>> +++ b/arch/arm/configs/vexpress_defconfig >>>> @@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y >>>> CONFIG_USB=y >>>> CONFIG_USB_ANNOUNCE_NEW_DEVICES=y >>>> CONFIG_USB_MON=y >>>> -CONFIG_USB_ISP1760_HCD=y >>>> CONFIG_USB_STORAGE=y >>>> +CONFIG_USB_ISP1760=y >>>> CONFIG_MMC=y >>>> CONFIG_MMC_ARMMMCI=y >>>> CONFIG_NEW_LEDS=y >>>> -- >>>> 1.9.1 >>> >>> >>> I tested this change and confirm that it does indeed re-activate USB >>> functionality. >> >> >> Thanks indeed. So I assume we can add >> >> Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > You sure can. > This has to go as fix, without this USB is not enabled with vexpress_defconfig and breaks for people using rootfs on USB on vepress platform. Regards, Sudeep
diff --git a/arch/arm/configs/vexpress_defconfig b/arch/arm/configs/vexpress_defconfig index f489fdaa19b8..37fe607a4ede 100644 --- a/arch/arm/configs/vexpress_defconfig +++ b/arch/arm/configs/vexpress_defconfig @@ -118,8 +118,8 @@ CONFIG_HID_ZEROPLUS=y CONFIG_USB=y CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_MON=y -CONFIG_USB_ISP1760_HCD=y CONFIG_USB_STORAGE=y +CONFIG_USB_ISP1760=y CONFIG_MMC=y CONFIG_MMC_ARMMMCI=y CONFIG_NEW_LEDS=y
Commt 7ef077a8ad35 ("usb: isp1760: Move driver from drivers/usb/host/ to drivers/usb/isp1760/") moved the isp1760 driver and changed the Kconfig option. This makes CONFIG_USB_ISP1760_HCD not selectable directly anymore. This results in driver being not compiled in when using vexpress_defconfig and the USB is non-functional. This patch updates the CONFIG_USB_ISP1760_HCD to CONFIG_USB_ISP1760 to get back USB functional on vexpress platforms. Cc: Liviu Dudau <liviu.dudau@arm.com> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- arch/arm/configs/vexpress_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)