| Message ID | 1424958600-18881-9-git-send-email-pali.rohar@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Herbert Xu |
| Headers | show |
On Thu 2015-02-26 14:49:58, Pali Rohár wrote: > This patch moves content of file omap34xx-hs.dtsi into omap3-n900.dts and enable > omap sham support (omap HW support for SHA + MD5). After testing both omap hwmod > and omap-sham.ko drivers it looks like signed Nokia X-Loader enable L3 firewall > for omap sham. There is no kernel crash with both official bootloader and crypto > enable bootloader. So we can safely enable sham code. > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> Acked-by: Pavel Machek <pavel@ucw.cz> > +/* > + * Default secure signed bootloader (Nokia X-Loader) does not enable L3 firewall > + * for omap AES HW crypto support. When linux kernel try to access memory of AES When Linux Kernel tries... > + * blocks then kernel receive "Unhandled fault: external abort on non-linefetch" , the kernel receives > + * and crash. Until somebody fix omap-aes.c and omap_hwmod_3xxx_data.c code (no and crashes. Until somebody fixes > + * crash anymore) omap AES support will be disabled for all Nokia N900 devices. > + * There is "unofficial" version of bootloader which enables AES in L3 firewall firewall, > + * but it is not widely used and to prevent kernel crash rather AES is disabled. > + * There is also no runtime detection code if AES is disabled in L3 firewall... > + */ > +&aes { > + status = "disabled"; > +}; > + > / { > model = "Nokia N900"; > compatible = "nokia,omap3-n900", "ti,omap3430", "ti,omap3";
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts index d16aa9c..10d5305 100644 --- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -9,9 +9,23 @@ /dts-v1/; -#include "omap34xx-hs.dtsi" +#include "omap34xx.dtsi" #include <dt-bindings/input/input.h> +/* + * Default secure signed bootloader (Nokia X-Loader) does not enable L3 firewall + * for omap AES HW crypto support. When linux kernel try to access memory of AES + * blocks then kernel receive "Unhandled fault: external abort on non-linefetch" + * and crash. Until somebody fix omap-aes.c and omap_hwmod_3xxx_data.c code (no + * crash anymore) omap AES support will be disabled for all Nokia N900 devices. + * There is "unofficial" version of bootloader which enables AES in L3 firewall + * but it is not widely used and to prevent kernel crash rather AES is disabled. + * There is also no runtime detection code if AES is disabled in L3 firewall... + */ +&aes { + status = "disabled"; +}; + / { model = "Nokia N900"; compatible = "nokia,omap3-n900", "ti,omap3430", "ti,omap3";
This patch moves content of file omap34xx-hs.dtsi into omap3-n900.dts and enable omap sham support (omap HW support for SHA + MD5). After testing both omap hwmod and omap-sham.ko drivers it looks like signed Nokia X-Loader enable L3 firewall for omap sham. There is no kernel crash with both official bootloader and crypto enable bootloader. So we can safely enable sham code. Signed-off-by: Pali Rohár <pali.rohar@gmail.com> --- arch/arm/boot/dts/omap3-n900.dts | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)