| Message ID | 1423526791-29453-5-git-send-email-sbranden@broadcom.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 09/02/15 16:06, Scott Branden wrote: > Add device tree binding documentation for IPROC SDHCI driver. > > Acked-by: Ray Jui <rjui@broadcom.com> > Signed-off-by: Corneliu Doban <cdoban@broadcom.com> > Signed-off-by: Scott Branden <sbranden@broadcom.com> > --- > .../devicetree/bindings/mmc/brcm,sdhci-iproc.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt > new file mode 100644 > index 0000000..72cc9cc > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt > @@ -0,0 +1,23 @@ > +Broadcom IPROC SDHCI controller > + > +This file documents differences between the core properties described > +by mmc.txt and the properties that represent the IPROC SDHCI controller. > + > +Required properties: > +- compatible : Should be "brcm,sdhci-iproc-cygnus". > +- clocks : The clock feeding the SDHCI controller. > + > +Optional properties: > + - sdhci,auto-cmd12: specifies that controller should use auto CMD12. Formatting is a little different here, there is one too many space to begin the line. > + > +Example: > + > +sdhci0: sdhci@0x18041000 { 0x is typically dropped from this part, to only appear in the "reg" property. > + compatible = "brcm,sdhci-iproc-cygnus"; > + reg = <0x18041000 0x100>; > + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&lcpll0_clks BCM_CYGNUS_LCPLL0_SDIO_CLK>; > + bus-width = <4>; > + sdhci,auto-cmd12; > + no-1-8-v; > +}; > Unless there is a re-spin, I will fix this myself while applying this patch to devicetree/next. Thanks
Hi Florian, On 15-03-02 03:50 PM, Florian Fainelli wrote: > > Unless there is a re-spin, I will fix this myself while applying this > patch to devicetree/next. > > Thanks > Yes, you can patch the formatting if the driver is being integrated. But I have had no response or feedback on the sdhci driver. It has been sitting for 1 month.
diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt new file mode 100644 index 0000000..72cc9cc --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt @@ -0,0 +1,23 @@ +Broadcom IPROC SDHCI controller + +This file documents differences between the core properties described +by mmc.txt and the properties that represent the IPROC SDHCI controller. + +Required properties: +- compatible : Should be "brcm,sdhci-iproc-cygnus". +- clocks : The clock feeding the SDHCI controller. + +Optional properties: + - sdhci,auto-cmd12: specifies that controller should use auto CMD12. + +Example: + +sdhci0: sdhci@0x18041000 { + compatible = "brcm,sdhci-iproc-cygnus"; + reg = <0x18041000 0x100>; + interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&lcpll0_clks BCM_CYGNUS_LCPLL0_SDIO_CLK>; + bus-width = <4>; + sdhci,auto-cmd12; + no-1-8-v; +};