diff mbox

[v2,2/3] arm64: qcom: Add support for Qualcomm MSM8916 SoC

Message ID 1425503602-24916-2-git-send-email-galak@codeaurora.org (mailing list archive)
State New, archived
Headers show

Commit Message

Kumar Gala March 4, 2015, 9:13 p.m. UTC 
From: Abhimanyu Kapur <abhimany@codeaurora.org>

Add support for Qualcomm MSM8916 SoC in arm64 Kconfig and defconfig.
Enable MSM8916 clock, pin control, and MSM serial driver utilized by
MSM8916 and Qualcomm SoCs in general.

Signed-off-by: Kumar Gala <galak@codeaurora.org>
Signed-off-by: Abhimanyu Kapur <abhimany@codeaurora.org>
---
v2:
* Dropped CONFIG_ARCH_QCOM_MSM8916, just use CONFIG_ARCH_QCOM
* Updated defconfig related to dropping CONFIG_ARCH_QCOM_MSM8916

 arch/arm64/Kconfig           | 9 +++++++++
 arch/arm64/configs/defconfig | 5 +++++
 2 files changed, 14 insertions(+)

Comments

Stephen Boyd March 4, 2015, 10:33 p.m. UTC | #1 
On 03/04/15 13:13, Kumar Gala wrote:
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1b8e973..4c8b119 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -177,6 +177,15 @@ config ARCH_MEDIATEK
>  	help
>  	  Support for Mediatek MT65xx & MT81xx ARMv8 SoCs
>  
> +config ARCH_QCOM
> +	bool "Qualcomm Platforms"
> +	select ARCH_REQUIRE_GPIOLIB
> +	select COMMON_CLK_QCOM
> +	select PINCTRL
> +	select SOC_BUS

I imagine all we need is select PINCTRL here. SOC_BUS is not used, also
we shouldn't force COMMON_CLK_QCOM to be Y instead of M so please drop
that select. Also we dropped ARCH_REQUIRE_GPIOLIB in arm32 so it would
match if we just relied on ARCH_WANT_GPIOLIB that arm64 has by default
Kumar Gala March 5, 2015, 3:06 p.m. UTC | #2 
On Mar 4, 2015, at 4:33 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:

> On 03/04/15 13:13, Kumar Gala wrote:
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 1b8e973..4c8b119 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -177,6 +177,15 @@ config ARCH_MEDIATEK
>> 	help
>> 	  Support for Mediatek MT65xx & MT81xx ARMv8 SoCs
>> 
>> +config ARCH_QCOM
>> +	bool "Qualcomm Platforms"
>> +	select ARCH_REQUIRE_GPIOLIB
>> +	select COMMON_CLK_QCOM
>> +	select PINCTRL
>> +	select SOC_BUS
> 
> I imagine all we need is select PINCTRL here. SOC_BUS is not used, also
> we shouldn't force COMMON_CLK_QCOM to be Y instead of M so please drop
> that select. Also we dropped ARCH_REQUIRE_GPIOLIB in arm32 so it would
> match if we just relied on ARCH_WANT_GPIOLIB that arm64 has by default

Will drop SOC_BUS.  We seem to have other arm64 platforms that set ARCH_REQUIRE_GPIOLIB.  Why should we not select COMMON_CLK_QCOM?  Can we do much useful without COMMON_CLK_QCOM set?

- k
Stephen Boyd March 5, 2015, 4:03 p.m. UTC | #3 
On 03/05, Kumar Gala wrote:
> 
> On Mar 4, 2015, at 4:33 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> 
> > On 03/04/15 13:13, Kumar Gala wrote:
> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> >> index 1b8e973..4c8b119 100644
> >> --- a/arch/arm64/Kconfig
> >> +++ b/arch/arm64/Kconfig
> >> @@ -177,6 +177,15 @@ config ARCH_MEDIATEK
> >> 	help
> >> 	  Support for Mediatek MT65xx & MT81xx ARMv8 SoCs
> >> 
> >> +config ARCH_QCOM
> >> +	bool "Qualcomm Platforms"
> >> +	select ARCH_REQUIRE_GPIOLIB
> >> +	select COMMON_CLK_QCOM
> >> +	select PINCTRL
> >> +	select SOC_BUS
> > 
> > I imagine all we need is select PINCTRL here. SOC_BUS is not used, also
> > we shouldn't force COMMON_CLK_QCOM to be Y instead of M so please drop
> > that select. Also we dropped ARCH_REQUIRE_GPIOLIB in arm32 so it would
> > match if we just relied on ARCH_WANT_GPIOLIB that arm64 has by default
> 
> Will drop SOC_BUS.  We seem to have other arm64 platforms that set ARCH_REQUIRE_GPIOLIB.  Why should we not select COMMON_CLK_QCOM?  Can we do much useful without COMMON_CLK_QCOM set?
> 

For gpiolib I was trying to say that it would match what we did
for ARCH_QCOM on arm32. The same is true for COMMON_CLK_QCOM.

We don't select these configs because they aren't required to
boot into a ramdisk that contains the clock driver and gpiolib
framework plus whatever disk driver and filesystem we may need to
access the (presumably) much larger disk that contains the rest
of the modules.
diff mbox

Patch

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 1b8e973..4c8b119 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -177,6 +177,15 @@  config ARCH_MEDIATEK
 	help
 	  Support for Mediatek MT65xx & MT81xx ARMv8 SoCs
 
+config ARCH_QCOM
+	bool "Qualcomm Platforms"
+	select ARCH_REQUIRE_GPIOLIB
+	select COMMON_CLK_QCOM
+	select PINCTRL
+	select SOC_BUS
+	help
+	  This enables support for the ARMv8 based Qualcomm chipsets.
+
 config ARCH_SEATTLE
 	bool "AMD Seattle SoC Family"
 	help
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index be1f12a..913bcb1 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -33,6 +33,7 @@  CONFIG_MODULE_UNLOAD=y
 # CONFIG_IOSCHED_DEADLINE is not set
 CONFIG_ARCH_FSL_LS2085A=y
 CONFIG_ARCH_MEDIATEK=y
+CONFIG_ARCH_QCOM=y
 CONFIG_ARCH_THUNDER=y
 CONFIG_ARCH_VEXPRESS=y
 CONFIG_ARCH_XGENE=y
@@ -93,11 +94,14 @@  CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_SERIAL_8250_MT6577=y
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
+CONFIG_SERIAL_MSM=y
+CONFIG_SERIAL_MSM_CONSOLE=y
 CONFIG_SERIAL_OF_PLATFORM=y
 CONFIG_VIRTIO_CONSOLE=y
 # CONFIG_HW_RANDOM is not set
 CONFIG_SPI=y
 CONFIG_SPI_PL022=y
+CONFIG_PINCTRL_MSM8916=y
 CONFIG_GPIO_PL061=y
 CONFIG_GPIO_XGENE=y
 # CONFIG_HWMON is not set
@@ -127,6 +131,7 @@  CONFIG_RTC_DRV_EFI=y
 CONFIG_RTC_DRV_XGENE=y
 CONFIG_VIRTIO_BALLOON=y
 CONFIG_VIRTIO_MMIO=y
+CONFIG_MSM_GCC_8916=y
 # CONFIG_IOMMU_SUPPORT is not set
 CONFIG_PHY_XGENE=y
 CONFIG_EXT2_FS=y