| Message ID | 54F08D7F.6050301@nokia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 85fa4e1f094183d230c47fa1e83373f692dc05ec |
| Headers | show |
On Fri, Feb 27, 2015 at 04:30:07PM +0100, Alexander Sverdlin wrote: > spi: pl022: Don't touch unspecified bits in interrupt mask > > PL022 Programmers model explicitely states "do not modify undefined register > bits". Correct the "all enable" interrupt mask so that it only enables defined > ones. Applied, thanks.
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index f68cbf6..0566657 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -278,7 +278,12 @@ */ #define DEFAULT_SSP_REG_IMSC 0x0UL #define DISABLE_ALL_INTERRUPTS DEFAULT_SSP_REG_IMSC -#define ENABLE_ALL_INTERRUPTS (~DEFAULT_SSP_REG_IMSC) +#define ENABLE_ALL_INTERRUPTS ( \ + SSP_IMSC_MASK_RORIM | \ + SSP_IMSC_MASK_RTIM | \ + SSP_IMSC_MASK_RXIM | \ + SSP_IMSC_MASK_TXIM \ +) #define CLEAR_ALL_INTERRUPTS 0x3
spi: pl022: Don't touch unspecified bits in interrupt mask PL022 Programmers model explicitely states "do not modify undefined register bits". Correct the "all enable" interrupt mask so that it only enables defined ones. Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com> --- drivers/spi/spi-pl022.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html