| Message ID | 1424447898-2791-1-git-send-email-nicolas.ferre@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Nicolas, On Fri, 20 Feb 2015 16:58:18 +0100 Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3 > that is forbidding the use of div1 prescaler. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> The "atmel,sama5d4-hlcdc" compatible string is not yet documented in the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > --- > drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c > index 522f7075bb1a..fa5feaba25a5 100644 > --- a/drivers/pwm/pwm-atmel-hlcdc.c > +++ b/drivers/pwm/pwm-atmel-hlcdc.c > @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = { > .compatible = "atmel,sama5d3-hlcdc", > .data = &atmel_hlcdc_pwm_sama5d3_errata, > }, > + { > + .compatible = "atmel,sama5d4-hlcdc", > + .data = &atmel_hlcdc_pwm_sama5d3_errata, > + }, > { /* sentinel */ }, > }; >
Le 20/02/2015 17:06, Boris Brezillon a écrit : > Hi Nicolas, > > On Fri, 20 Feb 2015 16:58:18 +0100 > Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > >> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3 >> that is forbidding the use of div1 prescaler. >> >> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > > The "atmel,sama5d4-hlcdc" compatible string is not yet documented in > the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so Yes, I'll document it when I'm submitting your patches that add the compatibility strings to the drivers/mfd/atmel-hlcdc.c. (with atmel,at91sam9x5-hlcdc as well). > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> Thanks, bye. >> --- >> drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c >> index 522f7075bb1a..fa5feaba25a5 100644 >> --- a/drivers/pwm/pwm-atmel-hlcdc.c >> +++ b/drivers/pwm/pwm-atmel-hlcdc.c >> @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = { >> .compatible = "atmel,sama5d3-hlcdc", >> .data = &atmel_hlcdc_pwm_sama5d3_errata, >> }, >> + { >> + .compatible = "atmel,sama5d4-hlcdc", >> + .data = &atmel_hlcdc_pwm_sama5d3_errata, >> + }, >> { /* sentinel */ }, >> }; >> > > >
On Fri, Feb 20, 2015 at 05:26:34PM +0100, Nicolas Ferre wrote: > Le 20/02/2015 17:06, Boris Brezillon a écrit : > > Hi Nicolas, > > > > On Fri, 20 Feb 2015 16:58:18 +0100 > > Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > > > >> sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3 > >> that is forbidding the use of div1 prescaler. > >> > >> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > > > > The "atmel,sama5d4-hlcdc" compatible string is not yet documented in > > the atmel-hlcdc MFD driver binding, but this shouldn't hurt, so > > Yes, I'll document it when I'm submitting your patches that add the > compatibility strings to the drivers/mfd/atmel-hlcdc.c. (with > atmel,at91sam9x5-hlcdc as well). > > > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> I'll take your word on it that this will be documented, so I've applied this. Thanks, Thierry
diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c index 522f7075bb1a..fa5feaba25a5 100644 --- a/drivers/pwm/pwm-atmel-hlcdc.c +++ b/drivers/pwm/pwm-atmel-hlcdc.c @@ -225,6 +225,10 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = { .compatible = "atmel,sama5d3-hlcdc", .data = &atmel_hlcdc_pwm_sama5d3_errata, }, + { + .compatible = "atmel,sama5d4-hlcdc", + .data = &atmel_hlcdc_pwm_sama5d3_errata, + }, { /* sentinel */ }, };
sama5d4 SoC also has an errata on the HLCDC PWM. It is the same as the sama5d3 that is forbidding the use of div1 prescaler. Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> --- drivers/pwm/pwm-atmel-hlcdc.c | 4 ++++ 1 file changed, 4 insertions(+)