diff mbox

Input: sx8654 - signedness bug in sx8654_irq()

Message ID 20150311093707.GC3564@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter March 11, 2015, 9:37 a.m. UTC 
"irqsrc" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Dmitry Torokhov March 11, 2015, 5:43 p.m. UTC | #1 
On Wed, Mar 11, 2015 at 12:37:07PM +0300, Dan Carpenter wrote:
> "irqsrc" needs to be signed for the error handling to work.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 

Applied, thank you.

> diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c
> index 8e531ac..aecb9ad 100644
> --- a/drivers/input/touchscreen/sx8654.c
> +++ b/drivers/input/touchscreen/sx8654.c
> @@ -79,7 +79,7 @@ struct sx8654 {
>  static irqreturn_t sx8654_irq(int irq, void *handle)
>  {
>  	struct sx8654 *sx8654 = handle;
> -	u8 irqsrc;
> +	int irqsrc;
>  	u8 data[4];
>  	unsigned int x, y;
>  	int retval;
diff mbox

Patch

diff --git a/drivers/input/touchscreen/sx8654.c b/drivers/input/touchscreen/sx8654.c
index 8e531ac..aecb9ad 100644
--- a/drivers/input/touchscreen/sx8654.c
+++ b/drivers/input/touchscreen/sx8654.c
@@ -79,7 +79,7 @@  struct sx8654 {
 static irqreturn_t sx8654_irq(int irq, void *handle)
 {
 	struct sx8654 *sx8654 = handle;
-	u8 irqsrc;
+	int irqsrc;
 	u8 data[4];
 	unsigned int x, y;
 	int retval;