| Message ID | 20150312135933.GA3502@udknight (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Mar 12, 2015 at 09:59:33PM +0800, Wang YanQing wrote: > "IPV6 || IPV6=n" means no dependence! Wow, this is all over the place.. find . -name 'Kconfig' | xargs grep 'depends on' |grep 'IPV6 || IPV6=n' > > Signed-off-by: Wang YanQing <udknight@gmail.com> > --- > drivers/net/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index df51d60..37b364f 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -40,7 +40,6 @@ if NET_CORE > config BONDING > tristate "Bonding driver support" > depends on INET > - depends on IPV6 || IPV6=n > ---help--- > Say 'Y' or 'M' if you wish to be able to 'bond' multiple Ethernet > Channels together. This is called 'Etherchannel' by Cisco, > -- > 2.2.2.dirty > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thursday 12 March 2015 21:59:33 Wang YanQing wrote:
> "IPV6 || IPV6=n" means no dependence!
IPV6 and BONDING are both tristate symbols and therefore this is not the same
as no dependency. When setting IPV6 to m, the expression evaluates to
"IPV6 || IPV6=n"
"m || m=n"
"m || n"
"m"
So, if IPV6=m, then BONDING can only be n or m, but not y.
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2015-03-12 at 16:14 +0100, Martin Walch wrote: > On Thursday 12 March 2015 21:59:33 Wang YanQing wrote: > > "IPV6 || IPV6=n" means no dependence! > > IPV6 and BONDING are both tristate symbols and therefore this is not the same > as no dependency. When setting IPV6 to m, the expression evaluates to > > "IPV6 || IPV6=n" > "m || m=n" > "m || n" > "m" > > So, if IPV6=m, then BONDING can only be n or m, but not y. Right. But it looks like bonding driver no longer has IPV6 dependencies. Patch should work, but the changelog should be changed to explain why the patch is valid, and this should be tested. Presumably we need to make sure the following builds and runs properly CONFIG_BONDING=y CONFIG_IPV6=m -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Wang YanQing <udknight@gmail.com> Date: Thu, 12 Mar 2015 21:59:33 +0800 > "IPV6 || IPV6=n" means no dependence! > > Signed-off-by: Wang YanQing <udknight@gmail.com> It is only nonsense because you don't actually understand what the statement does. It makes sure that either IPV6 is enabled and _EQUALS_ what BONDING is set to ("y" _or_ "m"), or it is disabled. This pattern is used all over the place and is quite common actually. Better to first ask what a statement does, than to knee-jerk submit a patch to remove it. Because patch submissions use up people's resources and time, particularly mine. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index df51d60..37b364f 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -40,7 +40,6 @@ if NET_CORE config BONDING tristate "Bonding driver support" depends on INET - depends on IPV6 || IPV6=n ---help--- Say 'Y' or 'M' if you wish to be able to 'bond' multiple Ethernet Channels together. This is called 'Etherchannel' by Cisco,
"IPV6 || IPV6=n" means no dependence! Signed-off-by: Wang YanQing <udknight@gmail.com> --- drivers/net/Kconfig | 1 - 1 file changed, 1 deletion(-)