| Message ID | 1426130037-17956-5-git-send-email-scottwood@freescale.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Scott Wood <scottwood@freescale.com> writes: > Use %pS for actual addresses, otherwise you'll get bad output > on arches like ppc64 where %pF expects a function descriptor. > > Signed-off-by: Scott Wood <scottwood@freescale.com> > Cc: linux-pm@vger.kernel.org > Cc: Kevin Hilman <khilman@kernel.org> > Cc: Nishanth Menon <nm@ti.com> Acked-by: Kevin Hilman <khilman@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/12/2015 01:09 PM, Kevin Hilman wrote: > Scott Wood <scottwood@freescale.com> writes: > >> Use %pS for actual addresses, otherwise you'll get bad output >> on arches like ppc64 where %pF expects a function descriptor. >> >> Signed-off-by: Scott Wood <scottwood@freescale.com> >> Cc: linux-pm@vger.kernel.org >> Cc: Kevin Hilman <khilman@kernel.org> >> Cc: Nishanth Menon <nm@ti.com> > > Acked-by: Kevin Hilman <khilman@linaro.org> > Acked-by: Nishanth Menon <nm@ti.com> I suppose this goes via Jiri Kosina's trivial tree?
On Thu, 12 Mar 2015, Nishanth Menon wrote: > > Scott Wood <scottwood@freescale.com> writes: > > > >> Use %pS for actual addresses, otherwise you'll get bad output > >> on arches like ppc64 where %pF expects a function descriptor. > >> > >> Signed-off-by: Scott Wood <scottwood@freescale.com> > >> Cc: linux-pm@vger.kernel.org > >> Cc: Kevin Hilman <khilman@kernel.org> > >> Cc: Nishanth Menon <nm@ti.com> > > > > Acked-by: Kevin Hilman <khilman@linaro.org> > > > Acked-by: Nishanth Menon <nm@ti.com> > > I suppose this goes via Jiri Kosina's trivial tree? Thanks. I am putting this on hold for a couple days to see who applied to which tree, gather acks, and merge what's outstanding through trivial tree.
diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c index db9973b..76d6a12 100644 --- a/drivers/power/avs/smartreflex.c +++ b/drivers/power/avs/smartreflex.c @@ -356,7 +356,7 @@ int sr_configure_errgen(struct omap_sr *sr) u8 senp_shift, senn_shift; if (!sr) { - pr_warn("%s: NULL omap_sr from %pF\n", __func__, + pr_warn("%s: NULL omap_sr from %pS\n", __func__, (void *)_RET_IP_); return -EINVAL; } @@ -423,7 +423,7 @@ int sr_disable_errgen(struct omap_sr *sr) u32 vpboundint_en, vpboundint_st; if (!sr) { - pr_warn("%s: NULL omap_sr from %pF\n", __func__, + pr_warn("%s: NULL omap_sr from %pS\n", __func__, (void *)_RET_IP_); return -EINVAL; } @@ -478,7 +478,7 @@ int sr_configure_minmax(struct omap_sr *sr) u8 senp_shift, senn_shift; if (!sr) { - pr_warn("%s: NULL omap_sr from %pF\n", __func__, + pr_warn("%s: NULL omap_sr from %pS\n", __func__, (void *)_RET_IP_); return -EINVAL; } @@ -563,7 +563,7 @@ int sr_enable(struct omap_sr *sr, unsigned long volt) int ret; if (!sr) { - pr_warn("%s: NULL omap_sr from %pF\n", __func__, + pr_warn("%s: NULL omap_sr from %pS\n", __func__, (void *)_RET_IP_); return -EINVAL; } @@ -615,7 +615,7 @@ int sr_enable(struct omap_sr *sr, unsigned long volt) void sr_disable(struct omap_sr *sr) { if (!sr) { - pr_warn("%s: NULL omap_sr from %pF\n", __func__, + pr_warn("%s: NULL omap_sr from %pS\n", __func__, (void *)_RET_IP_); return; }
Use %pS for actual addresses, otherwise you'll get bad output on arches like ppc64 where %pF expects a function descriptor. Signed-off-by: Scott Wood <scottwood@freescale.com> Cc: linux-pm@vger.kernel.org Cc: Kevin Hilman <khilman@kernel.org> Cc: Nishanth Menon <nm@ti.com> --- drivers/power/avs/smartreflex.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)