diff mbox

input: misc: pwm-beeper: remove useless call to pwm_config()

Message ID 1426165770-11130-1-git-send-email-olivier@sobrie.be (mailing list archive)
State New, archived
Headers show

Commit Message

Olivier Sobrie March 12, 2015, 1:09 p.m. UTC
Calling pwm_config() with a period equal to zero always results in
error (-EINVAL) and pwm chip config method is never called.

Signed-off-by: Olivier Sobrie <olivier@sobrie.be>
---
 drivers/input/misc/pwm-beeper.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Dmitry Torokhov March 12, 2015, 9:47 p.m. UTC | #1
On Thu, Mar 12, 2015 at 02:09:30PM +0100, Olivier Sobrie wrote:
> Calling pwm_config() with a period equal to zero always results in
> error (-EINVAL) and pwm chip config method is never called.
> 
> Signed-off-by: Olivier Sobrie <olivier@sobrie.be>

Applied, thank you.

> ---
>  drivers/input/misc/pwm-beeper.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index a28ee70..2a23643 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -50,7 +50,6 @@ static int pwm_beeper_event(struct input_dev *input,
>  	}
>  
>  	if (value == 0) {
> -		pwm_config(beeper->pwm, 0, 0);
>  		pwm_disable(beeper->pwm);
>  	} else {
>  		period = HZ_TO_NANOSECONDS(value);
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index a28ee70..2a23643 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -50,7 +50,6 @@  static int pwm_beeper_event(struct input_dev *input,
 	}
 
 	if (value == 0) {
-		pwm_config(beeper->pwm, 0, 0);
 		pwm_disable(beeper->pwm);
 	} else {
 		period = HZ_TO_NANOSECONDS(value);