| Message ID | 1425764475-27691-19-git-send-email-sakari.ailus@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sakari, Thank you for the patch. On Saturday 07 March 2015 23:41:15 Sakari Ailus wrote: > Print a warning when the driver is used with platform data. Existing > platform data user should move to DT now. > > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/platform/omap3isp/isp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c index 2c9bc0d..e4a78bb 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2447,6 +2447,8 @@ static int isp_probe(struct platform_device *pdev) > isp->syscon = syscon_regmap_lookup_by_pdevname("syscon.0"); > if (IS_ERR(isp->syscon)) > return PTR_ERR(isp->syscon); > + dev_warn(&pdev->dev, > + "Platform data support is deprecated! Please move to DT now! \n"); > } > > isp->autoidle = autoidle;
Hi, [+CC Tony] On Sat, Mar 07, 2015 at 11:41:15PM +0200, Sakari Ailus wrote: > Print a warning when the driver is used with platform data. Existing > platform data user should move to DT now. I guess this should become a more visible warning on OMAP SoC level, since platform data based boot will be deprecated completly. -- Sebastian
* Sebastian Reichel <sre@kernel.org> [150313 02:41]: > Hi, > > [+CC Tony] > > On Sat, Mar 07, 2015 at 11:41:15PM +0200, Sakari Ailus wrote: > > Print a warning when the driver is used with platform data. Existing > > platform data user should move to DT now. > > I guess this should become a more visible warning on OMAP SoC level, > since platform data based boot will be deprecated completly. Yeah. We should need platform data in addition to device tree data in only very few cases. Basically only when there's some arch specific callback function that needs to be passed to the driver. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 2c9bc0d..e4a78bb 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -2447,6 +2447,8 @@ static int isp_probe(struct platform_device *pdev) isp->syscon = syscon_regmap_lookup_by_pdevname("syscon.0"); if (IS_ERR(isp->syscon)) return PTR_ERR(isp->syscon); + dev_warn(&pdev->dev, + "Platform data support is deprecated! Please move to DT now!\n"); } isp->autoidle = autoidle;
Print a warning when the driver is used with platform data. Existing platform data user should move to DT now. Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi> --- drivers/media/platform/omap3isp/isp.c | 2 ++ 1 file changed, 2 insertions(+)