diff mbox

[libdrm,5/8] Fix aliasing and switch-enum warnings

Message ID 1425060448-5315-6-git-send-email-jan.vesely@rutgers.edu (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Vesely Feb. 27, 2015, 6:07 p.m. UTC 
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
---
 tests/exynos/exynos_fimg2d_test.c | 3 +++
 tests/modeprint/modeprint.c       | 1 +
 xf86drmMode.c                     | 2 +-
 3 files changed, 5 insertions(+), 1 deletion(-)

Comments

Emil Velikov March 13, 2015, 11:15 p.m. UTC | #1 
On 27 February 2015 at 18:07, Jan Vesely <jan.vesely@rutgers.edu> wrote:
> Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
> ---
>  tests/exynos/exynos_fimg2d_test.c | 3 +++
>  tests/modeprint/modeprint.c       | 1 +
>  xf86drmMode.c                     | 2 +-
>  3 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c
> index dc7c5cb..ba8d12c 100644
> --- a/tests/exynos/exynos_fimg2d_test.c
> +++ b/tests/exynos/exynos_fimg2d_test.c
> @@ -273,6 +273,7 @@ static int g2d_copy_test(struct exynos_device *dev, struct exynos_bo *src,
>                 src_img.user_ptr[0].userptr = userptr;
>                 src_img.user_ptr[0].size = size;
>                 break;
> +       case G2D_IMGBUF_COLOR:
>         default:
>                 type = G2D_IMGBUF_GEM;
>                 break;
> @@ -356,6 +357,7 @@ static int g2d_copy_with_scale_test(struct exynos_device *dev,
>                 src_img.user_ptr[0].userptr = userptr;
>                 src_img.user_ptr[0].size = size;
>                 break;
> +       case G2D_IMGBUF_COLOR:
>         default:
>                 type = G2D_IMGBUF_GEM;
>                 break;
> @@ -444,6 +446,7 @@ static int g2d_blend_test(struct exynos_device *dev,
>                 src_img.user_ptr[0].userptr = userptr;
>                 src_img.user_ptr[0].size = size;
>                 break;
> +       case G2D_IMGBUF_COLOR:
>         default:
>                 type = G2D_IMGBUF_GEM;
>                 break;
Hi Inki, Joonyoung

The above hunks look good imho, although a quick ack from an Exynos
person would be appreciated :-)

Cheers,
Emil
diff mbox

Patch

diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c
index dc7c5cb..ba8d12c 100644
--- a/tests/exynos/exynos_fimg2d_test.c
+++ b/tests/exynos/exynos_fimg2d_test.c
@@ -273,6 +273,7 @@  static int g2d_copy_test(struct exynos_device *dev, struct exynos_bo *src,
 		src_img.user_ptr[0].userptr = userptr;
 		src_img.user_ptr[0].size = size;
 		break;
+	case G2D_IMGBUF_COLOR:
 	default:
 		type = G2D_IMGBUF_GEM;
 		break;
@@ -356,6 +357,7 @@  static int g2d_copy_with_scale_test(struct exynos_device *dev,
 		src_img.user_ptr[0].userptr = userptr;
 		src_img.user_ptr[0].size = size;
 		break;
+	case G2D_IMGBUF_COLOR:
 	default:
 		type = G2D_IMGBUF_GEM;
 		break;
@@ -444,6 +446,7 @@  static int g2d_blend_test(struct exynos_device *dev,
 		src_img.user_ptr[0].userptr = userptr;
 		src_img.user_ptr[0].size = size;
 		break;
+	case G2D_IMGBUF_COLOR:
 	default:
 		type = G2D_IMGBUF_GEM;
 		break;
diff --git a/tests/modeprint/modeprint.c b/tests/modeprint/modeprint.c
index de59cbd..508c9f2 100644
--- a/tests/modeprint/modeprint.c
+++ b/tests/modeprint/modeprint.c
@@ -60,6 +60,7 @@  static const char* getConnectionText(drmModeConnection conn)
 		return "connected";
 	case DRM_MODE_DISCONNECTED:
 		return "disconnected";
+	case DRM_MODE_UNKNOWNCONNECTION:
 	default:
 		return "unknown";
 	}
diff --git a/xf86drmMode.c b/xf86drmMode.c
index 61d5e01..acb6c52 100644
--- a/xf86drmMode.c
+++ b/xf86drmMode.c
@@ -858,7 +858,7 @@  int drmHandleEvent(int fd, drmEventContextPtr evctx)
 
 	i = 0;
 	while (i < len) {
-		e = (struct drm_event *) &buffer[i];
+		e = (void *) &buffer[i];
 		switch (e->type) {
 		case DRM_EVENT_VBLANK:
 			if (evctx->version < 1 ||