diff mbox

[libdrm,3/3] configure.ac: error out if building freedreno_kgsl without freedreno

Message ID 1426551567-30354-3-git-send-email-emil.l.velikov@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Emil Velikov March 17, 2015, 12:19 a.m. UTC
The former is a subset of the latter. Error out early so the user is
aware that they are doing something very wrong.

Cc: Rob Clark <robdclark@gmail.com>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
---
 configure.ac | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Clark March 17, 2015, 1:07 a.m. UTC | #1
On Mon, Mar 16, 2015 at 8:19 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> The former is a subset of the latter. Error out early so the user is
> aware that they are doing something very wrong.
>
> Cc: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>

Reviewed-by: Rob Clark <robdclark@gmail.com>

> ---
>  configure.ac | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index fb5e6aa..fcb21df 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -322,6 +322,11 @@ if test "x$FREEDRENO" = xyes; then
>         AC_DEFINE(HAVE_FREEDRENO, 1, [Have freedreno support])
>  fi
>
> +if test "x$FREEDRENO_KGSL" = xyes; then
> +       if test "x$FREEDRENO" != xyes; then
> +               AC_MSG_ERROR([Cannot enable freedreno KGSL interface if freedreno is disabled])
> +       fi
> +fi
>  AM_CONDITIONAL(HAVE_FREEDRENO_KGSL, [test "x$FREEDRENO_KGSL" = xyes])
>  if test "x$FREEDRENO_KGSL" = xyes; then
>         AC_DEFINE(HAVE_FREEDRENO_KGSL, 1, [Have freedreno support for KGSL kernel interface])
> --
> 2.3.1
>
diff mbox

Patch

diff --git a/configure.ac b/configure.ac
index fb5e6aa..fcb21df 100644
--- a/configure.ac
+++ b/configure.ac
@@ -322,6 +322,11 @@  if test "x$FREEDRENO" = xyes; then
 	AC_DEFINE(HAVE_FREEDRENO, 1, [Have freedreno support])
 fi
 
+if test "x$FREEDRENO_KGSL" = xyes; then
+	if test "x$FREEDRENO" != xyes; then
+		AC_MSG_ERROR([Cannot enable freedreno KGSL interface if freedreno is disabled])
+	fi
+fi
 AM_CONDITIONAL(HAVE_FREEDRENO_KGSL, [test "x$FREEDRENO_KGSL" = xyes])
 if test "x$FREEDRENO_KGSL" = xyes; then
 	AC_DEFINE(HAVE_FREEDRENO_KGSL, 1, [Have freedreno support for KGSL kernel interface])