diff mbox

[libdrm,9/8] Remove drmSetDebugMsgFunction and related infrastructure

Message ID 1426703854-18692-2-git-send-email-jan.vesely@rutgers.edu (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Vesely March 18, 2015, 6:37 p.m. UTC
Not used anywhere

Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
---
 xf86drm.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

Comments

Emil Velikov March 20, 2015, 9:06 p.m. UTC | #1
On 18 March 2015 at 18:37, Jan Vesely <jan.vesely@rutgers.edu> wrote:
> Not used anywhere
>
Some information from my digging around:

Function was added with commit 79038751ffe(libdrm: add support for
server side functionality in libdrm).
It's not referenced even once in the history of the following projects
 - xserver
 - plymouth
 - mesa
 - xf86-video-ati
  -xf86-video-freedreno
 - xf86-video-i128
 - xf86-video-i740
 - xf86-video-intel
 - xf86-video-mach64
 - xf86-video-mga
 - xf86-video-nouveau
 - xf86-video-r128
 - xf86-video-tdfx
 - xf86-video-savage
 - xf86-video-sis
 - xf86-video-via

So I'm pretty confident that we're safe to nuke it. The above ddx list
should consist of all the drivers/hardware that was ever officially
supported by drm - from dri1 era until now.

Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

-Emil
Jan Vesely March 20, 2015, 9:42 p.m. UTC | #2
On Fri, 2015-03-20 at 21:06 +0000, Emil Velikov wrote:
> On 18 March 2015 at 18:37, Jan Vesely <jan.vesely@rutgers.edu> wrote:
> > Not used anywhere
> >
> Some information from my digging around:
> 
> Function was added with commit 79038751ffe(libdrm: add support for
> server side functionality in libdrm).
> It's not referenced even once in the history of the following projects
>  - xserver
>  - plymouth
>  - mesa
>  - xf86-video-ati
>   -xf86-video-freedreno
>  - xf86-video-i128
>  - xf86-video-i740
>  - xf86-video-intel
>  - xf86-video-mach64
>  - xf86-video-mga
>  - xf86-video-nouveau
>  - xf86-video-r128
>  - xf86-video-tdfx
>  - xf86-video-savage
>  - xf86-video-sis
>  - xf86-video-via
> 
> So I'm pretty confident that we're safe to nuke it. The above ddx list
> should consist of all the drivers/hardware that was ever officially
> supported by drm - from dri1 era until now.
> 
> Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

thanks for checking those. I still don;t have a clear idea which
projects actually use libdrm (other than mesa)

jan

> 
> -Emil
diff mbox

Patch

diff --git a/xf86drm.c b/xf86drm.c
index a309d57..ab472ea 100644
--- a/xf86drm.c
+++ b/xf86drm.c
@@ -114,11 +114,6 @@  drmDebugPrint(const char *format, va_list ap)
     return vfprintf(stderr, format, ap);
 }
 
-typedef int DRM_PRINTFLIKE(1, 0) (*debug_msg_func_t)(const char *format,
-						     va_list ap);
-
-static debug_msg_func_t drm_debug_print = drmDebugPrint;
-
 void
 drmMsg(const char *format, ...)
 {
@@ -130,18 +125,12 @@  drmMsg(const char *format, ...)
 	if (drm_server_info) {
 	  drm_server_info->debug_print(format,ap);
 	} else {
-	  drm_debug_print(format, ap);
+	  drmDebugPrint(format, ap);
 	}
 	va_end(ap);
     }
 }
 
-void
-drmSetDebugMsgFunction(debug_msg_func_t debug_msg_ptr)
-{
-    drm_debug_print = debug_msg_ptr;
-}
-
 static void *drmHashTable = NULL; /* Context switch callbacks */
 
 void *drmGetHashTable(void)